Fixed
Status Update
Comments
gy...@google.com <gy...@google.com>
mi...@gmail.com <mi...@gmail.com> #2
Trying to reproduce this on my 4.2.2 (v17) Nexus 4. Added this drawable:
<transition xmlns:android="http://schemas.android.com/apk/res/android " >
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="http://schemas.android.com/apk/res/android "
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
<transition xmlns:android="
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>
where blue/green drawables look like this:
<shape
xmlns:android="
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>
Then added this test:
@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);
Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}
It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.
gy...@google.com <gy...@google.com> #3
Also not reproducible on Galaxy Nexus running 4.0.1 (v14), 4.0.4 (v15) and 4.2.2 (v17)
ja...@google.com <ja...@google.com> #4
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit 69ba8494d775cb020432319718674c1ca538c0a6
Author: Jaewan Kim <jaewan@google.com>
Date: Tue Jan 26 14:03:44 2021
Add support for (prepare|play)From(MediaId|Uri|Search)
Bug: 176949057
Test: Run version compat tests
Relnote: Add support for (prepare|play)From(MediaId|Uri|Search)
Change-Id: I134757b3638d8581d54e75b5b85e76184ad96752
M media2/media2-session/api/current.txt
M media2/media2-session/api/public_plus_experimental_current.txt
M media2/media2-session/api/restricted_current.txt
M media2/media2-session/src/main/java/androidx/media2/session/MediaConstants.java
M media2/media2-session/src/main/java/androidx/media2/session/MediaController.java
M media2/media2-session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java
M media2/media2-session/version-compat-tests/current/client/src/androidTest/java/androidx/media2/test/client/tests/MediaControllerLegacyTest.java
M media2/media2-session/version-compat-tests/current/service/src/androidTest/java/androidx/media2/test/service/tests/MediaSessionCompatCallbackWithMediaControllerTest.java
https://android-review.googlesource.com/1560471
Branch: androidx-main
commit 69ba8494d775cb020432319718674c1ca538c0a6
Author: Jaewan Kim <jaewan@google.com>
Date: Tue Jan 26 14:03:44 2021
Add support for (prepare|play)From(MediaId|Uri|Search)
Bug: 176949057
Test: Run version compat tests
Relnote: Add support for (prepare|play)From(MediaId|Uri|Search)
Change-Id: I134757b3638d8581d54e75b5b85e76184ad96752
M media2/media2-session/api/current.txt
M media2/media2-session/api/public_plus_experimental_current.txt
M media2/media2-session/api/restricted_current.txt
M media2/media2-session/src/main/java/androidx/media2/session/MediaConstants.java
M media2/media2-session/src/main/java/androidx/media2/session/MediaController.java
M media2/media2-session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java
M media2/media2-session/version-compat-tests/current/client/src/androidTest/java/androidx/media2/test/client/tests/MediaControllerLegacyTest.java
M media2/media2-session/version-compat-tests/current/service/src/androidTest/java/androidx/media2/test/service/tests/MediaSessionCompatCallbackWithMediaControllerTest.java
Description
Component used: androidx.media2.session.MediaController
Version used: 1.1.0
Devices/Android versions reproduced on: Nexus S API 29, but it'll be same on any device.
Currently the
MediaControllerImplLegacy
blockssetMediaItem
calls (as well as calls tosetMediaUri
):It's not clear why, since implementation would look exactly the same as for many of the implemented calls, i.e. for
setMediaItem
:This is very important part of API and there's no good workaround.
Could anyone please see if it'd be possible to implement this? :)