[Media2] MediaControllerImplLegacy does not allow to setMediaItem (former playFromMediaId) [176949057]

Fixed

Bug

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

Jan 7, 2021 05:46PM

Component used: androidx.media2.session.MediaController

Version used: 1.1.0

Devices/Android versions reproduced on: Nexus S API 29, but it'll be same on any device.

Currently the MediaControllerImplLegacy blocks setMediaItem calls (as well as calls to setMediaUri):

@Override
public ListenableFuture<SessionResult> setMediaItem(@NonNull String mediaId) {
    return createFutureWithResult(RESULT_ERROR_NOT_SUPPORTED);
}

It's not clear why, since implementation would look exactly the same as for many of the implemented calls, i.e. for setMediaItem:

@Override
public ListenableFuture<SessionResult> setMediaItem(@NonNull String mediaId) {
    synchronized (mLock) {
        if (!mConnected) {
            Log.w(TAG, "Session isn't active", new IllegalStateException());
            return createFutureWithResult(RESULT_ERROR_SESSION_DISCONNECTED);
        }
        mControllerCompat.getTransportControls().playFromMediaId(mediaId, null);
        // or Bundle.EMPTY as a second argument, not sure if it matters
    }
    return createFutureWithResult(RESULT_SUCCESS);
}

This is very important part of API and there's no good workaround.

Could anyone please see if it'd be possible to implement this? :)

Comments

gy...@google.com <gy...@google.com> Jan 8, 2021 02:50AM

Reassigned to ja...@google.com.

mi...@gmail.com <mi...@gmail.com> #2Jan 14, 2021 10:32AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

gy...@google.com <gy...@google.com> #3Jan 18, 2021 12:07PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ja...@google.com <ja...@google.com> #4Jan 19, 2021 06:13AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5Feb 17, 2021 06:44AM

Project: platform/frameworks/support
Branch: androidx-main

commit 69ba8494d775cb020432319718674c1ca538c0a6
Author: Jaewan Kim <jaewan@google.com>
Date: Tue Jan 26 14:03:44 2021

Add support for (prepare|play)From(MediaId|Uri|Search)

Bug: 176949057
Test: Run version compat tests
Relnote: Add support for (prepare|play)From(MediaId|Uri|Search)
Change-Id: I134757b3638d8581d54e75b5b85e76184ad96752

M media2/media2-session/api/current.txt
M media2/media2-session/api/public_plus_experimental_current.txt
M media2/media2-session/api/restricted_current.txt
M media2/media2-session/src/main/java/androidx/media2/session/MediaConstants.java
M media2/media2-session/src/main/java/androidx/media2/session/MediaController.java
M media2/media2-session/src/main/java/androidx/media2/session/MediaControllerImplLegacy.java
M media2/media2-session/version-compat-tests/current/client/src/androidTest/java/androidx/media2/test/client/tests/MediaControllerLegacyTest.java
M media2/media2-session/version-compat-tests/current/service/src/androidTest/java/androidx/media2/test/service/tests/MediaSessionCompatCallbackWithMediaControllerTest.java

https://android-review.googlesource.com/1560471

ja...@google.com <ja...@google.com> Mar 8, 2021 07:45AM

Marked as fixed.

Issue 176949057