Fixed
Status Update
No update yet.
Comments
tc...@google.com
Hi,
I also see my text cut off when I set maxLines = 2. Is it the same issue?
Box(
modifier =
Modifier.size(
width = 108dp,
height = 34dp,
),
contentAlignment = Alignment.Center,
) {
BasicText(
text = "text text text",
maxLines = 2,
autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
)
}
ra...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <
Link:
Fix TextAutoSize bug with maxLines = 1
Expand for full commit details
Fix TextAutoSize bug with maxLines = 1
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult.
Test: New MultiParagraphLayoutCacheTests and manual testing
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1.
Fixes: 376834366
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689
Files:
- M
compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt - M
compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt
Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025
ap...@google.com
#2, yeah, that's the same issue.
ra...@google.com
Thanks @jo...@google.com for fixing this! Do you know when the fix would be available for g3 apps?
Description
val (focusRequester1, focusRequester2) = FocusRequester.FocusRequesterFactory
val (focusRequester1, focusRequester2) = FocusRequester.createRefs()
Things that we should improve on:
1. Both of these appear next to each other in autocomplete, and we would like users to use createRefs() instead of FocusRequesterFactory.
2. Issues relating to remembering the FocusRequester. (Not an issue for the functionality of FocusRequester, but if this pattern is used in other APIs that need remembered objects, this could be an issue)