AndroidX Media2 Package.getName() NPE [177060207]

Fixed

Bug

Status Update

No update yet.

Description

it...@gmail.com

created issue #1

Jan 9, 2021 02:14PM

Component used: media2-session

Version used: 1.1.1

Devices/Android versions reproduced on: SHIELD TV (Android 9), Redmi K20 (Android 11), Mi 9T Pro (Android 10)

Using a ExoPlayer with a MediaSessionService. Note that no extra session package verifiers are used, only inbuilt inside ExoPlayer's media2 extension.

Crashlog:

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Package.getName()' on a null object reference
       at androidx.versionedparcelable.VersionedParcel.findParcelClass(VersionedParcel.java:1630)
       at androidx.versionedparcelable.VersionedParcel.writeVersionedParcelableCreator(VersionedParcel.java:1042)
       at androidx.versionedparcelable.VersionedParcel.writeVersionedParcelable(VersionedParcel.java:1032)
       at androidx.versionedparcelable.VersionedParcel.writeVersionedParcelable(VersionedParcel.java:1022)
       at androidx.media2.session.SessionTokenParcelizer.write(SessionTokenParcelizer.java:22)
       at java.lang.reflect.Method.invoke(Method.java)
       at androidx.versionedparcelable.VersionedParcel.writeToParcel(VersionedParcel.java:1587)
       at androidx.versionedparcelable.VersionedParcel.writeVersionedParcelable(VersionedParcel.java:1035)
       at androidx.versionedparcelable.ParcelImpl.writeToParcel(ParcelImpl.java:57)
       at android.os.Parcel.writeParcelable(Parcel.java:10)
       at android.os.Parcel.writeValue(Parcel.java:104)
       at android.os.Parcel.writeArrayMapInternal(Parcel.java:30)
       at android.os.BaseBundle.writeToParcelInner(BaseBundle.java:81)
       at android.os.Bundle.writeToParcel(Bundle.java:13)
       at android.os.Parcel.writeBundle(Parcel.java:8)
       at android.os.Parcel.writeValue(Parcel.java:71)
       at android.os.Parcel.writeArrayMapInternal(Parcel.java:30)
       at android.os.BaseBundle.writeToParcelInner(BaseBundle.java:81)
       at android.os.Bundle.writeToParcel(Bundle.java:13)
       at com.android.internal.os.IResultReceiver$Stub$Proxy.send(IResultReceiver.java:19)
       at android.os.ResultReceiver.send(ResultReceiver.java:25)
       at android.support.v4.media.session.MediaSessionCompat$Callback$MediaSessionCallbackApi21.onCommand(MediaSessionCompat.java:1560)
       at android.media.session.MediaSession$CallbackMessageHandler.handleMessage(MediaSession.java:310)
       at android.os.Handler.dispatchMessage(Handler.java:19)
       at android.os.Looper.loop(Looper.java:249)
       at android.os.HandlerThread.run(HandlerThread.java:28)

Comments

gy...@google.com <gy...@google.com> #2Jan 11, 2021 12:44AM

Reassigned to gy...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

it...@gmail.com <it...@gmail.com> #3Jan 11, 2021 09:59AM

Well, most of the time NPE occurs randomly - the only requirement is running playback in a service.

Also, using apps for controlling playback from Amazfit/MiBand (like Notify for.. apps) causes this kind of crashes (for example, when clicking "Play" or "Pause" on the smartwatches).

One more way of causing NPE is to open Zepp (official app for controlling Amazfit watches) and go to "Played tracks" section while the playback service is running. App will try to fetch data about now playing track, but after that playback application will crash with a NPE.

gy...@google.com <gy...@google.com> #4Jan 12, 2021 02:13AM

Hi, could you try to add the dependency below to the build.gradle?

implementation 'androidx.versionedparcelable:versionedparcelable:1.1.1'

it...@gmail.com <it...@gmail.com> #5Jan 12, 2021 08:33AM

Added. Yes, it resolved the issue. Thanks for helping!

ap...@google.com <ap...@google.com> #6Jan 12, 2021 10:25PM

Project: platform/frameworks/support
Branch: androidx-main

commit b27cfef95fabcaccff48524ec87dec91bf74901b
Author: Alan Viverette <alanv@google.com>
Date: Tue Jan 12 09:52:14 2021

Update core dependency on VP for bugfix

Fixes: 177296655
Bug: 177060207
Test: n/a
Change-Id: I1f8e4205db604eabdbbfb8f7c40d915b5cd0af2f

M core/core/build.gradle

https://android-review.googlesource.com/1547256

ap...@google.com <ap...@google.com> #7Jan 13, 2021 07:00AM

Project: platform/frameworks/support
Branch: androidx-main

commit 26317fcfd23175637b84b45a0dcb4816f9f37e81
Author: Gyumin Sim <gyumin@google.com>
Date: Tue Jan 12 18:46:21 2021

Specify versionedparcelable version as 1.1.1 for media2

It makes media2 use versionedparcelable v1.1.1 to fix a bug where
package-private VersionedParcelable classes might be trimmed.

Bug: 177060207
Relnote: Fixed NPE from versionedparcelable
Test: ./gradlew -p media2 assembleDebug
Change-Id: I1ec281ddd52517b660374b8d57c5c6d925e38c12

M media2/common/build.gradle

https://android-review.googlesource.com/1547640

gy...@google.com <gy...@google.com> #8Jan 14, 2021 07:45AM

Marked as fixed.

It will be fixed by media2 1.1.2 which will be hopefully released in 2021-01-28. Then, the workaround at comment#4 won't be required.