AndroidX Media2 Package.getName() NPE [177060207]

Fixed

Bug

Status Update

No update yet.

Description

it...@gmail.com

created issue #1

Jan 9, 2021 02:14PM

Component used: media2-session

Version used: 1.1.1

Devices/Android versions reproduced on: SHIELD TV (Android 9), Redmi K20 (Android 11), Mi 9T Pro (Android 10)

Using a ExoPlayer with a MediaSessionService. Note that no extra session package verifiers are used, only inbuilt inside ExoPlayer's media2 extension.

Crashlog:

Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String java.lang.Package.getName()' on a null object reference
       at androidx.versionedparcelable.VersionedParcel.findParcelClass(VersionedParcel.java:1630)
       at androidx.versionedparcelable.VersionedParcel.writeVersionedParcelableCreator(VersionedParcel.java:1042)
       at androidx.versionedparcelable.VersionedParcel.writeVersionedParcelable(VersionedParcel.java:1032)
       at androidx.versionedparcelable.VersionedParcel.writeVersionedParcelable(VersionedParcel.java:1022)
       at androidx.media2.session.SessionTokenParcelizer.write(SessionTokenParcelizer.java:22)
       at java.lang.reflect.Method.invoke(Method.java)
       at androidx.versionedparcelable.VersionedParcel.writeToParcel(VersionedParcel.java:1587)
       at androidx.versionedparcelable.VersionedParcel.writeVersionedParcelable(VersionedParcel.java:1035)
       at androidx.versionedparcelable.ParcelImpl.writeToParcel(ParcelImpl.java:57)
       at android.os.Parcel.writeParcelable(Parcel.java:10)
       at android.os.Parcel.writeValue(Parcel.java:104)
       at android.os.Parcel.writeArrayMapInternal(Parcel.java:30)
       at android.os.BaseBundle.writeToParcelInner(BaseBundle.java:81)
       at android.os.Bundle.writeToParcel(Bundle.java:13)
       at android.os.Parcel.writeBundle(Parcel.java:8)
       at android.os.Parcel.writeValue(Parcel.java:71)
       at android.os.Parcel.writeArrayMapInternal(Parcel.java:30)
       at android.os.BaseBundle.writeToParcelInner(BaseBundle.java:81)
       at android.os.Bundle.writeToParcel(Bundle.java:13)
       at com.android.internal.os.IResultReceiver$Stub$Proxy.send(IResultReceiver.java:19)
       at android.os.ResultReceiver.send(ResultReceiver.java:25)
       at android.support.v4.media.session.MediaSessionCompat$Callback$MediaSessionCallbackApi21.onCommand(MediaSessionCompat.java:1560)
       at android.media.session.MediaSession$CallbackMessageHandler.handleMessage(MediaSession.java:310)
       at android.os.Handler.dispatchMessage(Handler.java:19)
       at android.os.Looper.loop(Looper.java:249)
       at android.os.HandlerThread.run(HandlerThread.java:28)

Comments

gy...@google.com <gy...@google.com> #2Jan 11, 2021 12:44AM

Reassigned to gy...@google.com.

Trying to reproduce this on my 4.2.2 (v17) Nexus 4. Added this drawable:

<transition xmlns:android="

http://schemas.android.com/apk/res/android" >
<item android:drawable="@drawable/test_drawable_blue"/>
<item android:drawable="@drawable/test_drawable_green"/>
</transition>

where blue/green drawables look like this:

<shape
xmlns:android="

http://schemas.android.com/apk/res/android"
android:shape="rectangle">
<size
android:width="@dimen/drawable_large_size"
android:height="@dimen/drawable_small_size" />
<solid
android:color="@color/test_blue" />
</shape>

Then added this test:

@Test
public void testMutateTransitionDrawable() {
Drawable drawable = ResourcesCompat.getDrawable(mResources,
R.drawable.test_transition_drawable, null);
assertTrue(drawable instanceof TransitionDrawable);

Drawable mutated = drawable.mutate();
assertTrue(drawable instanceof TransitionDrawable);
assertTrue(mutated instanceof TransitionDrawable);
}

It passes on the device. Going to also try on other earlier devices a bit later in the day once they are charged.

it...@gmail.com <it...@gmail.com> #3Jan 11, 2021 09:59AM

Also not reproducible on Galaxy Nexus running 4.0.1 (v14), 4.0.4 (v15) and 4.2.2 (v17)

gy...@google.com <gy...@google.com> #4Jan 12, 2021 02:13AM

https://android-review.googlesource.com/c/platform/frameworks/support/+/960032 with the test. Closing as not reproducible. If this is still happening for you, we'd need to see either a test (same as in this CL) or a small, standalone sample project that reproduces this issue on v17 (or other) devices.

it...@gmail.com <it...@gmail.com> #5Jan 12, 2021 08:33AM

Added. Yes, it resolved the issue. Thanks for helping!

ap...@google.com <ap...@google.com> #6Jan 12, 2021 10:25PM

Project: platform/frameworks/support
Branch: androidx-main

commit b27cfef95fabcaccff48524ec87dec91bf74901b
Author: Alan Viverette <alanv@google.com>
Date: Tue Jan 12 09:52:14 2021

Update core dependency on VP for bugfix

Fixes: 177296655
Bug: 177060207
Test: n/a
Change-Id: I1f8e4205db604eabdbbfb8f7c40d915b5cd0af2f

M core/core/build.gradle

https://android-review.googlesource.com/1547256

ap...@google.com <ap...@google.com> #7Jan 13, 2021 07:00AM

Project: platform/frameworks/support
Branch: androidx-main

commit 26317fcfd23175637b84b45a0dcb4816f9f37e81
Author: Gyumin Sim <gyumin@google.com>
Date: Tue Jan 12 18:46:21 2021

Specify versionedparcelable version as 1.1.1 for media2

It makes media2 use versionedparcelable v1.1.1 to fix a bug where
package-private VersionedParcelable classes might be trimmed.

Bug: 177060207
Relnote: Fixed NPE from versionedparcelable
Test: ./gradlew -p media2 assembleDebug
Change-Id: I1ec281ddd52517b660374b8d57c5c6d925e38c12

M media2/common/build.gradle

https://android-review.googlesource.com/1547640

gy...@google.com <gy...@google.com> #8Jan 14, 2021 07:45AM

Marked as fixed.

It will be fixed by media2 1.1.2 which will be hopefully released in 2021-01-28. Then, the workaround at comment#4 won't be required.