Fixed
Status Update
Comments
wu...@google.com <wu...@google.com>
ap...@google.com <ap...@google.com> #2
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
le...@google.com <le...@google.com> #3
Great! Thanks a lot, I'll look for the live updates soon!
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 194f428cd5b216b910177940fe9bc44143fa29a4
Author: leo huang <leohuang@google.com>
Date: Fri Jan 22 13:42:12 2021
Remove the validation of image saved location to improve the performance of taking picture
It is a nice feature to quickly fail by verifying the saved location before taking a picture, which can allow users to receive early notifications when the request will eventually fail. However, doing so will increase the latency a bit in taking pictures. Through trade-off considerations, remove the verification for better performance.
Relnote: "Fixed ImageCapture performance regression by removing the validation of image saved location before taking picture. After making this change, if the save destination is invalid, it will take longer to get the failure response because it will try to save the image after the photo is taken."
Bug: 177061560
Test: ./gradlew camera:camera-camera2:connectedAndroidTest
Change-Id: I1fd4ed93d0984668c634c832010901d604cb0dc6
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
D camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/DeviceQuirksLoader.java
D camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/HuaweiMediaStoreLocationValidationQuirk.java
D camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
https://android-review.googlesource.com/1559097
Branch: androidx-main
commit 194f428cd5b216b910177940fe9bc44143fa29a4
Author: leo huang <leohuang@google.com>
Date: Fri Jan 22 13:42:12 2021
Remove the validation of image saved location to improve the performance of taking picture
It is a nice feature to quickly fail by verifying the saved location before taking a picture, which can allow users to receive early notifications when the request will eventually fail. However, doing so will increase the latency a bit in taking pictures. Through trade-off considerations, remove the verification for better performance.
Relnote: "Fixed ImageCapture performance regression by removing the validation of image saved location before taking picture. After making this change, if the save destination is invalid, it will take longer to get the failure response because it will try to save the image after the photo is taken."
Bug: 177061560
Test: ./gradlew camera:camera-camera2:connectedAndroidTest
Change-Id: I1fd4ed93d0984668c634c832010901d604cb0dc6
M camera/camera-core/src/main/java/androidx/camera/core/ImageCapture.java
D camera/camera-core/src/main/java/androidx/camera/core/ImageSaveLocationValidator.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/DeviceQuirksLoader.java
D camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/HuaweiMediaStoreLocationValidationQuirk.java
D camera/camera-core/src/test/java/androidx/camera/core/ImageSaveLocationValidatorTest.java
wu...@google.com <wu...@google.com>
ju...@google.com <ju...@google.com> #6
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.2.0
Description
Tested on SM-J106H, beta05: 636 ms, rc01: 753 ms