Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit d1ba27ee2c5c6af767bac581a1ec1843f1351123
Author: Ralston Da Silva <ralu@google.com>
Date: Fri Jan 08 13:02:20 2021
Rename AmbientWindowManager to AmbientWindowInfo
This CL renames AmbientWindowManager to AmbientWindowInfo, and makes WindowFocusObserver internal.
Bug: 177084714
Bug: 177084983
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.platform.WindowInfoAmbientTest
Relnote: AmbientWindowManager is renamed to AmbientWindowInfo
Relnote: WindowFocusObserver is deprecated. Use AmbientWindowInfo.current.isWindowFocused instead
Change-Id: I2686a353413875efef5899b1122b75d12ee43af6
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/FocusInDialog.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/FocusInPopup.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/WindowInfoAmbientTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/Ambients.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/WindowInfo.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
https://android-review.googlesource.com/1544648
Branch: androidx-main
commit d1ba27ee2c5c6af767bac581a1ec1843f1351123
Author: Ralston Da Silva <ralu@google.com>
Date: Fri Jan 08 13:02:20 2021
Rename AmbientWindowManager to AmbientWindowInfo
This CL renames AmbientWindowManager to AmbientWindowInfo, and makes WindowFocusObserver internal.
Bug: 177084714
Bug: 177084983
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.platform.WindowInfoAmbientTest
Relnote: AmbientWindowManager is renamed to AmbientWindowInfo
Relnote: WindowFocusObserver is deprecated. Use AmbientWindowInfo.current.isWindowFocused instead
Change-Id: I2686a353413875efef5899b1122b75d12ee43af6
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/FocusInDialog.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/focus/FocusInPopup.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/platform/WindowInfoAmbientTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/Ambients.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/WindowInfo.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
Description
In general, we want to send state down the hierarchy, and events up. This API takes the state that is passed down and converts it into an event. Since it is not consistent with the general pattern followed in Compose, we should remove it.