Fragment's onResume() method is not called [177154873]

Fixed

Bug

Status Update

No update yet.

Description

ix...@gmail.com

created issue #1

Jan 10, 2021 11:17PM

Component used: Fragment

Version used: 1.3.0-rc01

Devices/Android versions reproduced on: Samsuns S10e/Android 10, Google Pixel 4XL/Android 11

Reproducing: Attached a sample app, look at MainActivity/MainActivityViewModel/FirstFragment.

Description of the issue:

I have stumbled upon a Fragment lifecycle issue where under certain conditions the Fragment#onResume() method does not get called. Conditions of reproducing:

Using AndroidX Fragment 1.3.0-rc01 (initially reproduced on 1.3.0-beta02, verified it is NOT fixed with the later release),
Using an enter transition in a Fragment transaction (ChangeBounds in my example),
Performing a Fragment transaction from Activity#onCreate() as a result of a LiveData emission.

It feels like some race condition, but is surprisingly stable at reproducing (pretty much at 100%, I only failed to reproduce it once on a fresh install) at different devices.

In the logs:

2021-01-10 15:05:29.242 21379-21379/com.example.fragmentnoresume I/DEBUG123: FirstFragment#onViewCreated
2021-01-10 15:05:29.250 21379-21379/com.example.fragmentnoresume I/DEBUG123: MainActivity#onResume

Any of the following actions fix the issue:

Removing the enter transition for the Fragment,
Switching to direct invocation or StateFlow instead of LiveData in Activity (for initiating a Fragment transaction),
Inserting a delay of 100+ms before starting the Fragment transaction:

private fun showFirstScreen() {
    val fragment = FirstFragment().apply {
        enterTransition = Fade()
    }

    lifecycleScope.launch {
        delay(100)
        supportFragmentManager.beginTransaction()
            .add(R.id.fragment_container, fragment, fragment.javaClass.name)
            .commitAllowingStateLoss()
    }
}

Once one of these workarounds has been applied, logs are like this:

2021-01-10 15:10:14.494 25298-25298/com.example.fragmentnoresume I/DEBUG123: MainActivity#onResume
2021-01-10 15:10:14.616 25298-25298/com.example.fragmentnoresume I/DEBUG123: FirstFragment#onViewCreated
2021-01-10 15:10:14.932 25298-25298/com.example.fragmentnoresume I/DEBUG123: FirstFragment#onResume

2021-01-10 15:13:03.312 25695-25695/com.example.fragmentnoresume I/DEBUG123: FirstFragment#onViewCreated
2021-01-10 15:13:03.316 25695-25695/com.example.fragmentnoresume I/DEBUG123: MainActivity#onResume
2021-01-10 15:13:03.316 25695-25695/com.example.fragmentnoresume I/DEBUG123: FirstFragment#onResume

FragmentNoResume.zip

879 KB

Download

Comments

ix...@gmail.com <ix...@gmail.com> #2Jan 10, 2021 11:20PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

il...@google.com <il...@google.com> Jan 12, 2021 01:07AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3Jan 16, 2021 02:14AM

Project: platform/frameworks/support
Branch: androidx-main

commit b57c42bc3a96fea02e15a732d1b7c22383eb010e
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Jan 14 14:11:48 2021

Ignore special effects for views not attachedToWindow

When adding fragments to the activity before the View hierarchy has been
attached to the window, if the fragment has special effects, they will
never be started. In the case of Transitions, this means there is never
an onEndTransition() callback, which causes fragment to be unable to
move to resumed.

Since unattached views will not run their transitions anyway, we should
drop any special effect operations before the special effects container
is attached to the window.

RelNote: "Fragments with transitions added before the view hierarchy is
attached now properly reach resumed."
Test: FragmentTransitionTest
Bug: 177154873

Change-Id: I1fc1db01450466f9ee012f07e4b608aa3337c838

M fragment/fragment/src/androidTest/AndroidManifest.xml
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentTransitionTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/SpecialEffectsController.java
M transition/transition/src/androidTest/AndroidManifest.xml
M transition/transition/src/androidTest/java/androidx/transition/FragmentTransitionTest.kt

https://android-review.googlesource.com/1551476

jb...@google.com <jb...@google.com> #4Jan 16, 2021 03:19AM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.3.0-rc02 release.

Issue 177154873

Description

Issue summary

Comments

ix...@gmail.com <ix...@gmail.com> #2Jan 10, 2021 11:20PM

il...@google.com <il...@google.com> Jan 12, 2021 01:07AM

ap...@google.com <ap...@google.com> #3Jan 16, 2021 02:14AM

jb...@google.com <jb...@google.com> #4Jan 16, 2021 03:19AM

Add comment

Issue metadata