Allow creation of Composition without going through Compositions static map [177245490]

Fixed

Bug

Status Update

No update yet.

Description

go...@jakewharton.com

created issue #1

Jan 12, 2021 02:58PM

The only way to create a Composition is through the compositionFor factory which goes through a static Compositions object which maintains a static weak map.

Adam P has tentatively said that removing this was in the plans. This is mostly just a tracking bug. Bonus: This means the expect/actual for WeakMap can be removed.

Comments

go...@jakewharton.com <go...@jakewharton.com> #2Jan 30, 2021 02:50AM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

so...@google.com <so...@google.com> #3Jun 18, 2021 02:42PM

Assigned to ad...@google.com.

Thanks for the report!

ad...@google.com <ad...@google.com> #4Jun 21, 2021 05:32PM

Marked as fixed.

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Issue 177245490

Description

Issue summary

Comments

go...@jakewharton.com <go...@jakewharton.com> #2Jan 30, 2021 02:50AM

so...@google.com <so...@google.com> #3Jun 18, 2021 02:42PM

ad...@google.com <ad...@google.com> #4Jun 21, 2021 05:32PM

Add comment

Issue metadata