Remove Uptime and Duration [177420019]

Fixed

Bug

Status Update

No update yet.

Description

mo...@google.com

created issue #1

Jan 13, 2021 04:19PM

Uptime and Duration should be removed APIs. Suspend functions and other kotlin methods use Long milliseconds to indicate durations currently and clock and durations are planned for a future release of kotlin. The best option is to use Long milliseconds as a replacement for most uses of Uptime and Duration and use Long nanoseconds in specific cases.

Comments

mo...@google.com <mo...@google.com> #2Jan 13, 2021 07:16PM

Reassigned to ti...@google.com.

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ti...@google.com <ti...@google.com> Jan 13, 2021 08:08PM

Accepted by ti...@google.com.

ap...@google.com <ap...@google.com> #3Jan 15, 2021 07:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

tc...@google.com <tc...@google.com> #4Jan 21, 2021 07:43PM

deleted

ap...@google.com <ap...@google.com> #5Jan 22, 2021 10:08PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ti...@google.com <ti...@google.com> #6Jan 22, 2021 10:18PM

Assigned to mo...@google.com.

Geroge, all Uptime usages have been removed from animation w/ CL in #5. I don't see much usage remained, aside from within ui-unit. I'll defer to you for deprecation or removal of the inline classes.

ap...@google.com <ap...@google.com> #7Jan 26, 2021 07:30PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit bfb88bdd0266423fe409c1b21946d29bf37e2c06
Author: George Mount <mount@google.com>
Date: Sat Jan 23 00:03:03 2021

Remove Uptime and Duration

Fixes: 177420019

Relnote: Uptime and Duration have been removed.

Test: compiles without the two classes
Change-Id: Ib9bf443043fdcc8ed2b27666b301d52fb3064d65

M compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/Cache.kt
M compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/platform/DesktopFont.kt
M compose/ui/ui-text/src/desktopTest/kotlin/androidx/compose/ui/text/CacheTest.kt
M compose/ui/ui-unit/api/current.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/api/restricted_current.txt
D compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Duration.kt
D compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Uptime.kt
D compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/DurationTest.kt
D compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/UptimeTest.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/desktop/AWTDebounceEventQueue.kt

https://android-review.googlesource.com/1556009