Fixed
Status Update
Comments
mo...@google.com <mo...@google.com> #2
ti...@google.com <ti...@google.com>
ap...@google.com <ap...@google.com> #3
Thanks for the report!
tc...@google.com <tc...@google.com> #4
The release notes documentation has been edited to clarify this change in behavior for line height.
To support non-standard text sizes, we encourage users to follow the Material design system and use a different style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified)
, or create a custom Typography
entirely.
ap...@google.com <ap...@google.com> #5
deleted
ti...@google.com <ti...@google.com> #6
In my case, I have multiple font sizes in the same Text
(using SpanStyle
in AnnotatedString
). There are legitimate reasons for this. For example, when combining Chinese and English (phonetic) together (for language-learning purposes).
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit bfb88bdd0266423fe409c1b21946d29bf37e2c06
Author: George Mount <mount@google.com>
Date: Sat Jan 23 00:03:03 2021
Remove Uptime and Duration
Fixes: 177420019
Relnote: Uptime and Duration have been removed.
Test: compiles without the two classes
Change-Id: Ib9bf443043fdcc8ed2b27666b301d52fb3064d65
M compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/Cache.kt
M compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/platform/DesktopFont.kt
M compose/ui/ui-text/src/desktopTest/kotlin/androidx/compose/ui/text/CacheTest.kt
M compose/ui/ui-unit/api/current.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/api/restricted_current.txt
D compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Duration.kt
D compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Uptime.kt
D compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/DurationTest.kt
D compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/UptimeTest.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/desktop/AWTDebounceEventQueue.kt
https://android-review.googlesource.com/1556009
Branch: androidx-main
commit bfb88bdd0266423fe409c1b21946d29bf37e2c06
Author: George Mount <mount@google.com>
Date: Sat Jan 23 00:03:03 2021
Remove Uptime and Duration
Fixes: 177420019
Relnote: Uptime and Duration have been removed.
Test: compiles without the two classes
Change-Id: Ib9bf443043fdcc8ed2b27666b301d52fb3064d65
M compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/Cache.kt
M compose/ui/ui-text/src/desktopMain/kotlin/androidx/compose/ui/text/platform/DesktopFont.kt
M compose/ui/ui-text/src/desktopTest/kotlin/androidx/compose/ui/text/CacheTest.kt
M compose/ui/ui-unit/api/current.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/api/restricted_current.txt
D compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Duration.kt
D compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/Uptime.kt
D compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/DurationTest.kt
D compose/ui/ui-unit/src/test/kotlin/androidx/compose/ui/unit/UptimeTest.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/desktop/AWTDebounceEventQueue.kt
Description
Uptime and Duration should be removed APIs. Suspend functions and other kotlin methods use Long milliseconds to indicate durations currently and clock and durations are planned for a future release of kotlin. The best option is to use Long milliseconds as a replacement for most uses of Uptime and Duration and use Long nanoseconds in specific cases.