Deprecate AnimatedFloat/Value/Color [177457083]

Fixed

Feature Request

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jan 13, 2021 09:43PM

The work involved is:

Remove all AnimatedFoo usage from public API
Write up a migration path from AnimatedFoo to the new Animatable, and add that to the API doc.
Mark AnimatedFoo @Deprecate, and suppress deprecation in places where it's used as impl detail before all usages are migrated to new suspend APIs.
Remove AnimatedFoo from animation lib (this may happen later)

Comments

ap...@google.com <ap...@google.com> #2Jan 15, 2021 02:01AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Jan 25, 2021 05:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 082882b45b4f332b1a6a319604153bbcbd9bf756
Author: Doris Liu <tianliu@google.com>
Date: Thu Jan 21 12:15:12 2021

Deprecate AnimatedValue/Float

This is the first step of the deprecation, which marks the
APIs as @Deprecate. The remaining work is for each component
that uses AnimatedFloat/Value to move onto the
new Animatable API.

RelNote: "AnimatedValue/Float is now deprecated. Please use
Animatable instead."

Bug: 177457083
Test: Removed

Change-Id: I713457f88b04e50fbc5deb70a5bb7bbcf777e630

M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimatedValue.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/DynamicTargetAnimation.kt
D compose/animation/animation-core/src/test/java/androidx/compose/animation/core/AnimatedValueTest.kt
M compose/animation/animation-core/src/test/java/androidx/compose/animation/core/TypeConverterTest.kt
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedValueEffects.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimationModifier.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/Crossfade.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/EnterExitTransition.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/animation/FlingConfig.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Zoomable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldCursor.kt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/ScaffoldSamples.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/ModalBottomSheet.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SnackbarHost.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Swipeable.kt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/LayerModifierSamples.kt

https://android-review.googlesource.com/1556513

cl...@google.com <cl...@google.com> Jan 26, 2021 05:32PM

Assigned to ti...@google.com.

ap...@google.com <ap...@google.com> #4Jan 27, 2021 07:31PM

Project: platform/frameworks/support
Branch: androidx-main

commit e908f36986a2a2b1adc6f9ac3890c0e3e964c47b
Author: Doris Liu <tianliu@google.com>
Date: Mon Jan 25 22:12:34 2021

Migrate animateContentSize to Animatable

RelNote: "Updated Modifier.animateContentSize API to be consistent
with the rest of the animation system."

Bug: 177457083
Test: Updated
Change-Id: I0bf752ff98bd11094a834099cbd1b42c600ebcaf

M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/src/androidAndroidTest/kotlin/androidx/compose/animation/AnimationModifierTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimationModifier.kt

https://android-review.googlesource.com/1559981

ap...@google.com <ap...@google.com> #5Jan 27, 2021 11:03PM

Project: platform/frameworks/support
Branch: androidx-main

commit b78571e5e6c03de373857162141f099fecb10a70
Author: Doris Liu <tianliu@google.com>
Date: Mon Jan 25 20:53:20 2021

Migrate Crossfade from using AnimatedFloat to using transition v2

Relnote: "Updated Crossfade's method signature to be more consistent
with the rest of the animation system."

Bug: 177457083
Test: All existing tests pass
Change-Id: Ib05ed5405bd4a781d2d78c84b7c06c0d153e8dc2

M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/CrossfadeDemo.kt
M compose/animation/animation/samples/src/main/java/androidx/compose/animation/samples/CrossfadeSample.kt
M compose/animation/animation/src/androidAndroidTest/kotlin/androidx/compose/animation/CrossfadeTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/Crossfade.kt

https://android-review.googlesource.com/1559996

ap...@google.com <ap...@google.com> #6Feb 3, 2021 06:40AM

Project: platform/frameworks/support
Branch: androidx-main

commit 3286e61018fe0f1dd1aa3c2978ea4d347c630b21
Author: Doris Liu <tianliu@google.com>
Date: Tue Feb 02 15:17:32 2021

Migrate AnimatedVisibility from AnimatedFoo to Animatable

Relnote: "Unified the param name for AnimationSpec to animationSpec
across the animation system. Also constrain the Enter/ExitTransition
to accept FiniteAnimationSpec."

Test: All tests pass
Bug: 177457083

Change-Id: Ie47c54ef91d1a4330e4d6f0f18ec3cde78d903ad

M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/AnimatedVisibilityDemo.kt
M compose/animation/animation/samples/src/main/java/androidx/compose/animation/samples/AnimatedVisibilitySamples.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedVisibility.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/EnterExitTransition.kt

https://android-review.googlesource.com/1570789

ap...@google.com <ap...@google.com> #7Feb 4, 2021 03:53PM

Project: platform/frameworks/support
Branch: androidx-main

commit b98e676468ea3f3a07549c2d873b9e1bce944205
Author: Doris Liu <tianliu@google.com>
Date: Wed Feb 03 18:17:31 2021

Remove deprecated animate, animatedValue, AnimatedValue

Relnote: "animate, animatedValue, AnimatedValue APIs have
been removed"

Bug: 177457083
Bug: 175134945
Test: Already removed

Change-Id: If27bc4f86851a978239709a6f7ddab8ec94070ca

M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimateAsState.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimatedValue.kt
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/samples/src/main/java/androidx/compose/animation/samples/AnimatedValueSamples.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedValueEffects.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/SingleValueAnimation.kt

https://android-review.googlesource.com/1573623

ap...@google.com <ap...@google.com> #8Feb 4, 2021 11:08PM

Project: platform/frameworks/support
Branch: androidx-main

commit 42c913ab535f0d76554e6805aa9995f2fa6222df
Author: Doris Liu <tianliu@google.com>
Date: Wed Feb 03 11:44:37 2021

Move zoomable, Slider, SnackbarHost to suspend animation

Relnote: "ZoomableController.smoothScaleBy and
ZoomableController.stopAnimation are now suspend functions."

Bug: 177457083
Test: Updated and passed
Change-Id: I7f970ebd60086d3fbe4d805ac115de749bbd4240

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ZoomableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Zoomable.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SnackbarHost.kt

https://android-review.googlesource.com/1573402

ap...@google.com <ap...@google.com> #9Feb 6, 2021 04:56AM

Project: platform/frameworks/support
Branch: androidx-main

commit 0a55e899914b1398bed87b33303b083b2efcd418
Author: Doris Liu <tianliu@google.com>
Date: Thu Feb 04 16:28:30 2021

Remove AnimationClockObservable and AnimatedFloat

RelNote: "AnimationClockObservable and subclasses have been
removed. AnimatedFloat has been removed."

Note: this CL is based on aosp/1576426 and aosp/1570862, but
the parent pointer isn't pointing to either of those. This is
to prevent the rebasing of this CL from accidentally uploading
patches to the two CLs above, creating unnecessary churns.

Bug: 177457083
Bug: 178448485

Test: removed
Change-Id: Icde5248072620b741bdf4d8cf59291e7b2994e6a

M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
D compose/animation/animation-core/src/androidMain/kotlin/androidx/compose/animation/core/AndroidAnimationClock.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimatedValue.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/Animation.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimationClock.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimationClockObservable.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/DynamicTargetAnimation.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/ManualFrameClock.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/MonotonicFrameAnimationClock.kt
D compose/animation/animation-core/src/test/java/androidx/compose/animation/core/AnimationClockTest.kt
M compose/animation/animation-core/src/test/java/androidx/compose/animation/core/AnimationTest.kt
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
D compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedValueEffects.kt
D compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/DisposableAnimationClock.kt
D compose/animation/animation/src/test/kotlin/androidx/compose/animation/DisposableAnimationClockTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/animation/FlingConfig.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/gestures/DesktopScrollableTest.kt
D compose/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/AnimationClockBenchmark.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/MonotonicFrameClockTestRule.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/CoroutineBuilders.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidCompositionLocals.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwners.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/Wrapper.kt

https://android-review.googlesource.com/1576077

ti...@google.com <ti...@google.com> #10Feb 6, 2021 06:40AM

Remaining work for this issue: Remove TargetAnimation API after its last client moves away from it: https://android-review.googlesource.com/c/platform/frameworks/support/+/1576439

Message last modified on Feb 9, 2021 05:50PM

ap...@google.com <ap...@google.com> #11Feb 9, 2021 09:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit 1b90334880260ad5c1f0fde255fd1b6715221844
Author: Doris Liu <tianliu@google.com>
Date: Mon Feb 08 17:59:28 2021

Remove TargetAnimation API

TargetAnimation was used as a part of the AnimatedFloat/Value
API. Now that all usages have been migrated onto the new
suspend animation API. No need to keep this around any more.

Also removes unused @ExperimentalAnimationApi import in material.

RelNote: TargetAnimation API has been removed.

Bug: 177457083
Test: all tests pass
Change-Id: If47d1f88096955c131af20c1660a5c450d5b7ed9

M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
A compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimationEndReason.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/DynamicTargetAnimation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt

https://android-review.googlesource.com/1580890

ti...@google.com <ti...@google.com> Feb 9, 2021 11:01PM

Marked as fixed.