Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
cl...@google.com <cl...@google.com>
ap...@google.com <ap...@google.com> #4
deleted
ap...@google.com <ap...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 3286e61018fe0f1dd1aa3c2978ea4d347c630b21
Author: Doris Liu <tianliu@google.com>
Date: Tue Feb 02 15:17:32 2021
Migrate AnimatedVisibility from AnimatedFoo to Animatable
Relnote: "Unified the param name for AnimationSpec to animationSpec
across the animation system. Also constrain the Enter/ExitTransition
to accept FiniteAnimationSpec."
Test: All tests pass
Bug: 177457083
Change-Id: Ie47c54ef91d1a4330e4d6f0f18ec3cde78d903ad
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/AnimatedVisibilityDemo.kt
M compose/animation/animation/samples/src/main/java/androidx/compose/animation/samples/AnimatedVisibilitySamples.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedVisibility.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/EnterExitTransition.kt
https://android-review.googlesource.com/1570789
Branch: androidx-main
commit 3286e61018fe0f1dd1aa3c2978ea4d347c630b21
Author: Doris Liu <tianliu@google.com>
Date: Tue Feb 02 15:17:32 2021
Migrate AnimatedVisibility from AnimatedFoo to Animatable
Relnote: "Unified the param name for AnimationSpec to animationSpec
across the animation system. Also constrain the Enter/ExitTransition
to accept FiniteAnimationSpec."
Test: All tests pass
Bug: 177457083
Change-Id: Ie47c54ef91d1a4330e4d6f0f18ec3cde78d903ad
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/AnimatedVisibilityDemo.kt
M compose/animation/animation/samples/src/main/java/androidx/compose/animation/samples/AnimatedVisibilitySamples.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedVisibility.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/EnterExitTransition.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit b98e676468ea3f3a07549c2d873b9e1bce944205
Author: Doris Liu <tianliu@google.com>
Date: Wed Feb 03 18:17:31 2021
Remove deprecated animate, animatedValue, AnimatedValue
Relnote: "animate, animatedValue, AnimatedValue APIs have
been removed"
Bug: 177457083
Bug: 175134945
Test: Already removed
Change-Id: If27bc4f86851a978239709a6f7ddab8ec94070ca
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimateAsState.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimatedValue.kt
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/samples/src/main/java/androidx/compose/animation/samples/AnimatedValueSamples.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedValueEffects.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/SingleValueAnimation.kt
https://android-review.googlesource.com/1573623
Branch: androidx-main
commit b98e676468ea3f3a07549c2d873b9e1bce944205
Author: Doris Liu <tianliu@google.com>
Date: Wed Feb 03 18:17:31 2021
Remove deprecated animate, animatedValue, AnimatedValue
Relnote: "animate, animatedValue, AnimatedValue APIs have
been removed"
Bug: 177457083
Bug: 175134945
Test: Already removed
Change-Id: If27bc4f86851a978239709a6f7ddab8ec94070ca
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimateAsState.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimatedValue.kt
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/samples/src/main/java/androidx/compose/animation/samples/AnimatedValueSamples.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedValueEffects.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/SingleValueAnimation.kt
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-main
commit 42c913ab535f0d76554e6805aa9995f2fa6222df
Author: Doris Liu <tianliu@google.com>
Date: Wed Feb 03 11:44:37 2021
Move zoomable, Slider, SnackbarHost to suspend animation
Relnote: "ZoomableController.smoothScaleBy and
ZoomableController.stopAnimation are now suspend functions."
Bug: 177457083
Test: Updated and passed
Change-Id: I7f970ebd60086d3fbe4d805ac115de749bbd4240
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ZoomableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Zoomable.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SnackbarHost.kt
https://android-review.googlesource.com/1573402
Branch: androidx-main
commit 42c913ab535f0d76554e6805aa9995f2fa6222df
Author: Doris Liu <tianliu@google.com>
Date: Wed Feb 03 11:44:37 2021
Move zoomable, Slider, SnackbarHost to suspend animation
Relnote: "ZoomableController.smoothScaleBy and
ZoomableController.stopAnimation are now suspend functions."
Bug: 177457083
Test: Updated and passed
Change-Id: I7f970ebd60086d3fbe4d805ac115de749bbd4240
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ZoomableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Zoomable.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/SnackbarHost.kt
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-main
commit 0a55e899914b1398bed87b33303b083b2efcd418
Author: Doris Liu <tianliu@google.com>
Date: Thu Feb 04 16:28:30 2021
Remove AnimationClockObservable and AnimatedFloat
RelNote: "AnimationClockObservable and subclasses have been
removed. AnimatedFloat has been removed."
Note: this CL is based on aosp/1576426 and aosp/1570862, but
the parent pointer isn't pointing to either of those. This is
to prevent the rebasing of this CL from accidentally uploading
patches to the two CLs above, creating unnecessary churns.
Bug: 177457083
Bug: 178448485
Test: removed
Change-Id: Icde5248072620b741bdf4d8cf59291e7b2994e6a
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
D compose/animation/animation-core/src/androidMain/kotlin/androidx/compose/animation/core/AndroidAnimationClock.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimatedValue.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/Animation.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimationClock.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimationClockObservable.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/DynamicTargetAnimation.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/ManualFrameClock.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/MonotonicFrameAnimationClock.kt
D compose/animation/animation-core/src/test/java/androidx/compose/animation/core/AnimationClockTest.kt
M compose/animation/animation-core/src/test/java/androidx/compose/animation/core/AnimationTest.kt
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
D compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedValueEffects.kt
D compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/DisposableAnimationClock.kt
D compose/animation/animation/src/test/kotlin/androidx/compose/animation/DisposableAnimationClockTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/animation/FlingConfig.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/gestures/DesktopScrollableTest.kt
D compose/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/AnimationClockBenchmark.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/MonotonicFrameClockTestRule.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/CoroutineBuilders.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidCompositionLocals.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwners.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/Wrapper.kt
https://android-review.googlesource.com/1576077
Branch: androidx-main
commit 0a55e899914b1398bed87b33303b083b2efcd418
Author: Doris Liu <tianliu@google.com>
Date: Thu Feb 04 16:28:30 2021
Remove AnimationClockObservable and AnimatedFloat
RelNote: "AnimationClockObservable and subclasses have been
removed. AnimatedFloat has been removed."
Note: this CL is based on aosp/1576426 and aosp/1570862, but
the parent pointer isn't pointing to either of those. This is
to prevent the rebasing of this CL from accidentally uploading
patches to the two CLs above, creating unnecessary churns.
Bug: 177457083
Bug: 178448485
Test: removed
Change-Id: Icde5248072620b741bdf4d8cf59291e7b2994e6a
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
D compose/animation/animation-core/src/androidMain/kotlin/androidx/compose/animation/core/AndroidAnimationClock.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimatedValue.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/Animation.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimationClock.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimationClockObservable.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/DynamicTargetAnimation.kt
M compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/ManualFrameClock.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/MonotonicFrameAnimationClock.kt
D compose/animation/animation-core/src/test/java/androidx/compose/animation/core/AnimationClockTest.kt
M compose/animation/animation-core/src/test/java/androidx/compose/animation/core/AnimationTest.kt
M compose/animation/animation/api/current.txt
M compose/animation/animation/api/public_plus_experimental_current.txt
M compose/animation/animation/api/restricted_current.txt
D compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimatedValueEffects.kt
D compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/DisposableAnimationClock.kt
D compose/animation/animation/src/test/kotlin/androidx/compose/animation/DisposableAnimationClockTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/animation/FlingConfig.kt
M compose/foundation/foundation/src/desktopTest/kotlin/androidx/compose/foundation/gestures/DesktopScrollableTest.kt
D compose/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/AnimationClockBenchmark.kt
M compose/test-utils/src/commonMain/kotlin/androidx/compose/testutils/AnimationClocks.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/MonotonicFrameClockTestRule.kt
M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/androidMain/kotlin/androidx/compose/ui/test/CoroutineBuilders.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidCompositionLocals.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/platform/CompositionLocals.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwners.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/Wrapper.kt
ti...@google.com <ti...@google.com> #10
ap...@google.com <ap...@google.com> #11
Project: platform/frameworks/support
Branch: androidx-main
commit 1b90334880260ad5c1f0fde255fd1b6715221844
Author: Doris Liu <tianliu@google.com>
Date: Mon Feb 08 17:59:28 2021
Remove TargetAnimation API
TargetAnimation was used as a part of the AnimatedFloat/Value
API. Now that all usages have been migrated onto the new
suspend animation API. No need to keep this around any more.
Also removes unused @ExperimentalAnimationApi import in material.
RelNote: TargetAnimation API has been removed.
Bug: 177457083
Test: all tests pass
Change-Id: If47d1f88096955c131af20c1660a5c450d5b7ed9
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
A compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimationEndReason.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/DynamicTargetAnimation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
https://android-review.googlesource.com/1580890
Branch: androidx-main
commit 1b90334880260ad5c1f0fde255fd1b6715221844
Author: Doris Liu <tianliu@google.com>
Date: Mon Feb 08 17:59:28 2021
Remove TargetAnimation API
TargetAnimation was used as a part of the AnimatedFloat/Value
API. Now that all usages have been migrated onto the new
suspend animation API. No need to keep this around any more.
Also removes unused @ExperimentalAnimationApi import in material.
RelNote: TargetAnimation API has been removed.
Bug: 177457083
Test: all tests pass
Change-Id: If47d1f88096955c131af20c1660a5c450d5b7ed9
M compose/animation/animation-core/api/current.txt
M compose/animation/animation-core/api/public_plus_experimental_current.txt
M compose/animation/animation-core/api/restricted_current.txt
A compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/AnimationEndReason.kt
D compose/animation/animation-core/src/commonMain/kotlin/androidx/compose/animation/core/DynamicTargetAnimation.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
Description
The work involved is:
AnimatedFoo
usage from public APIAnimatedFoo
to the new Animatable, and add that to the API doc.AnimatedFoo
@Deprecate, and suppress deprecation in places where it's used as impl detail before all usages are migrated to new suspend APIs.AnimatedFoo
from animation lib (this may happen later)