IssueTracker

there are some image for help

hello?

ListenableFuture.await extension in kotlinx-coroutines-guava will work. Please feel free to reopen it and suggest any idea that would be useful if they were in the media specific extension library.

Sure it'll work, but it sends the message that our media libraries aren't Kotlin-friendly.

This could be an excellent opportunity for a Media KTX library. Many of our other AndroidX libraries have KTX libs for similar reasons (https://developer.android.com/kotlin/ktx). It should be relatively simple to wrap ListenableFutures with suspend functions.

Here's an example from the camera2 lib: https://github.com/androidx/androidx/blob/e28b71f805a3624f28d1ef26db3e9e561e88b93b/camera/camera-camera2-pipe-integration/src/main/java/androidx/camera/camera2/pipe/integration/adapter/SessionConfigAdapter.kt#L122

Hi Don, I see the point of Kotlin-friendliness. I do think it's nice to provide ktx if it benefits users.

I'm wondering how much it will benefit the developers to provide suspend extension functions wrapping APIs returning ListenableFuture. Then, the code would be:

implementation 'androidx.media2:media2-session-ktx:1.2.0'

mediaController.awaitPlay() // suspend function

It will need the same effort as:

implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-guava:1.5.20'

mediaController.play().await()

I think the latter would be more flexible/resilient if there were some missing wrappers in the media ktx.

From the class design point of view, ListenableFuture is a common interface defined in Guava not specifically in the media library. So, extension for ListenableFuture should be in a Guava extension for more consistant interface. If there were two different libraries that expose ListenableFutures and have their own Kotlin extensions to wrap the ListenableFutures as suspend functions, the code might have inconsistency using the ListenableFutures.

Please let me know if I'm missing something or if there are other examples for extensions than ListenableFuture.

There is AndroidX Concurrent that has a Kotlin extension that adds a suspend function await() for ListenableFutures. With this, integration into Coroutines was easy for me. I'm not super experienced with Kotlin but this was helpful for integrating with Coroutines:

Sample (pseudo) code:

init {
        viewModelScope.launch {
            val mediaItemList = mediaBrowser.getChildren(parentId, 0, 100, null).value!!
            // do something with the mediaItemList
        }
    }

https://developer.android.com/jetpack/androidx/releases/concurrent