Fixed
Status Update
Comments
po...@google.com <po...@google.com>
an...@google.com <an...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
mo...@google.com <mo...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
vs...@gmail.com <vs...@gmail.com> #4
deleted
ae...@google.com <ae...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit 940f677411cf9f83c5bfceb6f6db588de846e48b
Author: George Mount <mount@google.com>
Date: Fri Jan 15 20:59:22 2021
OnSizeChanged now reports the size within the modifier chain.
Relnote: "OnSizeChanged was reporting the size of the layout's
contents. It now reports the size at its position within the
modifier chain."
Fixes: 177562900
Test: new test
Change-Id: I36b78f445cf90b10f3df4ea6251bc19392bb7c11
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/OnSizeChangedTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/OnRemeasuredModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/RemeasureModifierWrapper.kt
https://android-review.googlesource.com/1552681
Branch: androidx-main
commit 940f677411cf9f83c5bfceb6f6db588de846e48b
Author: George Mount <mount@google.com>
Date: Fri Jan 15 20:59:22 2021
OnSizeChanged now reports the size within the modifier chain.
Relnote: "OnSizeChanged was reporting the size of the layout's
contents. It now reports the size at its position within the
modifier chain."
Fixes: 177562900
Test: new test
Change-Id: I36b78f445cf90b10f3df4ea6251bc19392bb7c11
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/OnSizeChangedTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/OnRemeasuredModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/RemeasureModifierWrapper.kt
Description
Jetpack Compose release version: 1.0.0-alpha10
Steps to Reproduce:
Expected printout:
150 x 150
Actual printout:
50 x 50
On the other hand if I replace
onSizeChanged
withlayout
it prints expected result.