onSizeChanged reports size without padding [177562900]

Fixed

Bug

Status Update

No update yet.

Description

vs...@gmail.com

created issue #1

Jan 14, 2021 06:35PM

Jetpack Compose release version: 1.0.0-alpha10

Steps to Reproduce:

@Preview
@Composable
fun Test() {
    val density = AmbientDensity.current
    Box(
        modifier = Modifier
            .onSizeChanged { println(it) }
            .padding(with(density) { 50.toDp() })
            .size(with(density) { 50.toDp() })
            .background(Color.Red)
    )
}

Expected printout: 150 x 150
Actual printout: 50 x 50

On the other hand if I replace onSizeChanged with layout it prints expected result.

modifier = Modifier
    .layout { measurable, constraints ->
        val placeable = measurable.measure(constraints)
        println("${placeable.width} x ${placeable.height}")
        layout(placeable.width, placeable.height) {
            placeable.place(0, 0)
        }
    }
    .padding(with(density) { 50.toDp() })
    .size(with(density) { 50.toDp() })
    .background(Color.Red)

Comments

po...@google.com <po...@google.com> Jan 14, 2021 06:39PM

Assigned to an...@google.com.

an...@google.com <an...@google.com> #2Jan 14, 2021 07:10PM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

mo...@google.com <mo...@google.com> #3Jan 14, 2021 08:33PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

vs...@gmail.com <vs...@gmail.com> #4Jan 14, 2021 09:13PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ae...@google.com <ae...@google.com> #5Jan 14, 2021 09:58PM

I see. We just ran into this in a foundation component CL as well: https://android-review.googlesource.com/c/platform/frameworks/support/+/1537302/5..6/compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt#b445 . We are forced to introduce an extra Box because of the current behavior.

ap...@google.com <ap...@google.com> #6Jan 19, 2021 08:27PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 940f677411cf9f83c5bfceb6f6db588de846e48b
Author: George Mount <mount@google.com>
Date: Fri Jan 15 20:59:22 2021

OnSizeChanged now reports the size within the modifier chain.

Relnote: "OnSizeChanged was reporting the size of the layout's
contents. It now reports the size at its position within the
modifier chain."

Fixes: 177562900
Test: new test
Change-Id: I36b78f445cf90b10f3df4ea6251bc19392bb7c11

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/OnSizeChangedTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/OnRemeasuredModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/RemeasureModifierWrapper.kt

https://android-review.googlesource.com/1552681

Issue 177562900