Wrong screen is resumed when popping screens sequentially [177590791]

Fixed

Bug

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

Jan 15, 2021 03:42AM

Library version used: 1.0.0-beta.1
Devices/Android versions reproduced on: Pixel 5/Android 11, DHU
Android Auto version reproduced on: 5.8.604354-release

Situation

Sample project to trigger the issue: https://github.com/themics/android-auto-screen-stack-bug

Let's say we have a screen stack of [A, B, C]. A is the root, and C is the top.

B is pushed by A for some result via screenManager.pushForResult(). So is C by B.

When C set the result and finish() itself, B also set that result and finish() itself to relay the result to A.

Now we have [A] and A is resumed properly. C and B is destroyed as well.

Problem

B's lifecycle is resumed again.

Log

(open an app)
12:35:00.566 I/AScreen: state: ON_CREATE
12:35:00.577 I/AScreen: state: ON_START
12:35:00.579 I/AScreen: state: ON_RESUME

(push B)
12:35:02.325 I/BScreen: state: ON_CREATE
12:35:02.326 I/BScreen: state: ON_START
12:35:02.326 I/AScreen: state: ON_PAUSE
12:35:02.327 I/AScreen: state: ON_STOP
12:35:02.327 I/BScreen: state: ON_RESUME

(push C)
12:35:03.521 I/CScreen: state: ON_CREATE
12:35:03.522 I/CScreen: state: ON_START
12:35:03.522 I/BScreen: state: ON_PAUSE
12:35:03.522 I/BScreen: state: ON_STOP
12:35:03.522 I/CScreen: state: ON_RESUME

(pop C & B)
12:35:04.441 I/BScreen: state: ON_START
12:35:04.442 I/CScreen: state: ON_PAUSE
12:35:04.442 I/CScreen: state: ON_STOP
12:35:04.442 I/AScreen: state: ON_START
12:35:04.442 I/BScreen: state: ON_STOP
12:35:04.443 I/BScreen: state: ON_DESTROY
12:35:04.443 I/AScreen: state: ON_RESUME
12:35:04.444 I/CScreen: state: ON_DESTROY
12:35:04.444 I/BScreen: state: ON_CREATE   <- problem
12:35:04.444 I/BScreen: state: ON_START    <- problem
12:35:04.444 I/BScreen: state: ON_RESUME   <- problem

Comments

jo...@google.com <jo...@google.com> #2Jan 20, 2021 07:29PM

Assigned to li...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

li...@google.com <li...@google.com> #3Jan 25, 2021 10:20PM

I found the issue. There is a bug where if you have nested screens pushed for result (as you do A pushing B and B pushing C), and you call finish inside of B's onScreenResultCallback, this causes the bug you see above.

We will be making a fix and rolling it out in an update of the library.

In the meantime, if you need to do this, you can get around the issue by calling ScreenManager#popTo(String) with a marker to Screen A.

jo...@google.com <jo...@google.com> #4Feb 2, 2021 05:27PM

The fix will be in the Jetpack version of the library, in the meantime, please use the workaround described in #3.

sh...@google.com <sh...@google.com> Feb 11, 2021 05:31PM

Marked as fixed.

ag...@gmail.com <ag...@gmail.com> #5Mar 4, 2021 06:17PM

Try reviewing the sequence in a group, from opening of an app Ascreen states ON_CREATE then ends in ON_RESUME.
Second group is (push b), Bscreen states ON_CREATE in first and close or ends states Bscreen ON_RESUME.
Third one states Cscreen in ON_CREATE also ends states with ON_RESUME.
So in (push c & b) states first at Bscreen in ON_CREATE, then it will states in ON_RESUME, even they are state in a middle part was ON_DESTROY, it will back in a ON_RESUME state at END of the bug.
Therefore, a rotation of sequence in a bug was sequentially.
Hope this help... 😇