toString() produces extra '}' [177761088]

Fixed

Bug

Status Update

No update yet.

Description

mf...@gmail.com

created issue #1

Jan 18, 2021 09:42AM

Component used: Fragment
Version used:
Devices/Android versions reproduced on:

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

When calling toString on a androidx.fragment.app.Fragment a string is produced with an extra '}'
The source code calls 'sb.append("{");' once and 'sb.append("})";' twice.

see the example output below.

onAttachFragment: TicketListFragment{2738801} (275d67bc-b525-4373-bbe7-349c06a67650) id=0x7f0900a3 List_Fragment}

Comments

il...@google.com <il...@google.com> Jan 19, 2021 07:06PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Feb 25, 2021 10:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 822b94312ab0e71054dcf8c007d4d8b6ba61db98
Author: Clara Fok <clarafok@google.com>
Date: Wed Dec 06 16:09:13 2023

Refactor PagingDataDiffer PageEvent processing

Streamline the process in preparation for upcoming refactors

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: I809a5197633e9d7167388160509bec00566d7417

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagePresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt

https://android-review.googlesource.com/2871509

jb...@google.com <jb...@google.com> #3Feb 25, 2021 11:36PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit fb741839c9be2e2a0a9e023bbba3c0cbac3c9ebb
Author: Clara Fok <clarafok@google.com>
Date: Wed Dec 06 16:22:46 2023

Rename PagePresenter to PageStore

PageStore will be refactored to only process and store loaded data.

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: Ic3502d2a541e02355d65cc5154025a0301a50ec5

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageStoreTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/ProcessPageEventCallbackCapture.kt

https://android-review.googlesource.com/2871510

Issue 177761088

Description

Issue summary

Comments

il...@google.com <il...@google.com> Jan 19, 2021 07:06PM

ap...@google.com <ap...@google.com> #2Feb 25, 2021 10:50PM

jb...@google.com <jb...@google.com> #3Feb 25, 2021 11:36PM

Add comment

Issue metadata