Status Update
Comments
il...@google.com <il...@google.com>
jb...@google.com <jb...@google.com> #2
Can you attach a sample project that reproduces your issue?
an...@google.com <an...@google.com> #3
I'm experiencing this issue in a commercial non-open source project so I'd have to provide extracted code fragments. The menu file for instance looks similar to this:
<menu>
<item
android:id="@+id/destination_one" />
<item
android:id="@+id/destination_two" />
<item
android:id="@+id/destination_three" />
<item
android:id="@+id/destination_four" />
</menu>
The menu item ids match the top level destination ids as for instance destination_one as required by the NavigationUI library.
The xml layout file of the main activity (there is only one activity) looks pretty much like this:
<androidx.coordinatorlayout.widget.CoordinatorLayout>
<androidx.constraintlayout.widget.ConstraintLayout>
<androidx.fragment.app.FragmentContainerView
android:id="@+id/navigation_host_fragment"
android:name="androidx.navigation.fragment.NavHostFragment"
android:layout_width="match_parent"
android:layout_height="0dp"
app:defaultNavHost="true"
app:layout_constraintBottom_toTopOf="@id/bottom_navigation"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toTopOf="parent"
app:navGraph="@navigation/main_navigation" />
<com.google.android.material.bottomnavigation.BottomNavigationView
android:id="@+id/bottom_navigation"
android:layout_width="match_parent"
android:layout_height="wrap_content"
app:layout_constraintBottom_toBottomOf="parent"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/navigation_host_fragment"
app:menu="@menu/main_menu" />
</androidx.constraintlayout.widget.ConstraintLayout>
</androidx.coordinatorlayout.widget.CoordinatorLayout>
The main_navigation
is the first navigation graph I posted in the original post. The behavior I described above only affects the first bottomNavigation item which corresponds to the top level navGraph's startDestination.
jb...@google.com <jb...@google.com> #4
Yeah, what we're looking for is a full project (i.e., take a brand new project in Android Studio, put your few bits of code in, and make sure your problem reproduces) as there are a lot of little pieces that can make a difference here.
an...@google.com <an...@google.com> #5
Of course the logic of my project is more sophisticated but this reproduces the issue quite well. If you click the first BottomNavigation item N times you need N+1 system back navigation triggers to leave the app.
jb...@google.com <jb...@google.com> #6
So first, we plan to get rid of these APIs in the future. The only behavior for NavigationUI will be to always save and restore the state of the back stack. Luckily, NavigationUI is purposely built only on publicly available APIs so you could always copy our code and make your custom adjustments for whatever your desired behavior is.
The source of the bug is
We need to add a fix to ensure we take into account the proper destination on our side, but as I mentioned those APIs will go away in the future. So if you wanted to proactively create your own API, you could make your API navigate directly to the start destination instead of the graph. That would allow you to not wait on our release and ensure you always have your desired behavior going forward.
co...@gmail.com <co...@gmail.com> #7
Thanks a lot for your help! I basically removed the first embedded graph by moving the code directly into the topmost navGraph and as you said, navigate directly to the start destination. As far as I can tell, it seems to work now.
an...@google.com <an...@google.com> #8
Branch: androidx-main
commit 5624b7cefcfe5e0abb01f1063b040e5f2f135b75
Author: Clara Fok <clarafok@google.com>
Date: Wed Nov 30 16:47:38 2022
Clean up launchSingleTop logic
Basic refactoring in preparation for fix to
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 253256629
Change-Id: Ib65764c345451d8be4613f6e3d278cc1a170091e
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
ja...@google.com <ja...@google.com> #9
Branch: androidx-main
commit f433d5458950a632900f8a2685ce6eab27272f8c
Author: Clara Fok <clarafok@google.com>
Date: Thu Dec 01 15:52:28 2022
Fix BottomNavView launchSingleTop with NavGraph
NavController previously did not apply launchSingleTop when user repeatedly navigates to the starting destination of a Menu when this starting destination is a NavGraph. This results in the destination being added mulitple times to backstack.
Now NavController checks if the destination is a NavGraph and if so, adds all destinations from the node to its final startDestination (i.e. nested nav graphs) to singleTop.
NavController backstack and Navigator backstacks entries are replaced accordingly upon singleTop navigations.
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 253256629
Relnote: singleTop now works with NavGraph such that if the top destination of the backstack is a NavGraph's startDestination, all destinations starting from original destination to its startDestination will only be added to the top of the backstack once.
Change-Id: Id4bea16aff3dd776826fc6d746475e293eb64b0e
M navigation/navigation-common/src/main/java/androidx/navigation/NavigatorState.kt
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
jb...@google.com <jb...@google.com> #10
This has been fixed internally and will be available in Navigation 2.6.0-alpha05
ap...@google.com <ap...@google.com> #11
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-common:2.6.0-alpha05
androidx.navigation:navigation-runtime:2.6.0-alpha05
jb...@google.com <jb...@google.com> #12
This has been fixed internally and will be released as part of the Navigation 2.3.4
version.
You can verify this by following the snapshot instructions with build id 7177928
and switching your navigation dependency to 2.4.0-SNAPSHOT
. Note that this will need to be an explicit dependency on navigation-runtime
in addition to the dependency on navigation-compose
.
ap...@google.com <ap...@google.com> #13
Branch: androidx-main
commit b76fc769718910bb2630c5e8c951d50df38e4d58
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 02 09:22:58 2021
Bump nav-compose nav dependency to 2.3.4
Making nav-compose depend on navigation-runtime 2.3.4 for a fix to no-op
when setting the same ViewModelStore.
RelNote: "Navigation Compose now depends on Navigation version 2.3.4
which includes the fix for attempting to set the same ViewModelStore
object after the graph has been set."
Test: NavHostTest
Bug: 177825470
Change-Id: I65c24fcd5674c1ac72715c612854aac62c2eda88
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
jb...@google.com <jb...@google.com> #14
Now that Navigation compose depends on navigation-runtime 2.3.4
, you can use the navigation-compose
1.0.0-SNAPSHOT
with buildId 7179952
.
Description
Android Studio Build: AF4
This happens when using nested navigation
val navController = rememberNavController()
NavHost(navController = navController) {
navigation {
something(navController) {
}}}
and in NavGraphBuilder.something:
composable{
onCommit(onboardingComplete) {
if (!onboardingComplete) {
navController.navigate(MainDestinations.ONBOARDING_ROUTE)
}
}}
Commenting this line out yields no crashes and navController.navigate() is used in many other places.
Not sure if it has to do with nested nav, but it worked fine with two nested navhosts.
I've uploaded a fork of Owl where this happens:
Crash in: Owl/app/src/main/java/com/example/owl/ui/courses/Courses.kt