Status Update
No update yet.
Comments
il...@google.com
jb...@google.com
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
an...@google.com
jb...@google.com
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
an...@google.com
jb...@google.com
It looks that way. I attached screen shots from the first and second calls to the onCommit() scope and the objects are the same for both passes.
co...@gmail.com
I've run into this issue and it happens when NavHost is recomposed but where you have the line calling rememberNavController() isn't recomposed.
I think the best solution is to move the navController set up code into rememberNavController() and make NavHost() just render the contents.
For me, this became an issue using Scaffold(). I'm trying to disable the drawer by setting drawerContent to null but this causes it to recompose and the NavHost in the body causes it to crash.
an...@google.com
ja...@google.com
jb...@google.com
Currently working on a potential fix in aosp/1591051. Do you have an updated version of the app that uses the latest compose? If so I could check if that fix addresses your use case.
As far as work arounds, to avoid the crash you can clear the back stack when the NavHost is disposed by adding
onDispose {
while (navController.popBackStack()) { }
}
ap...@google.com
Branch: androidx-main
commit e2280407cf218dd031a8f74dba2b4d709fc3e826
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Mar 01 11:43:16 2021
No-op for same ViewModelStore and LifecycleOwner
When attempting to setViewModelStore or setLifecycleOwner if the
parameter passed in is the same as the one already set on the
NavController, the call should be a no-op.
RelNote: "Calling setViewModelStore or setLifecycleOwner with the same
object that has already been set will now be a no-op"
Test: NavControllerTest
Bug: 177825470
Change-Id: Idf491fa68c0771dd617832cefe4c03e8ea85dae7
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
jb...@google.com
This has been fixed internally and will be released as part of the Navigation 2.3.4 version.
You can verify this by following the snapshot instructions with build id 7177928 and switching your navigation dependency to 2.4.0-SNAPSHOT. Note that this will need to be an explicit dependency on navigation-runtime in addition to the dependency on navigation-compose.
ap...@google.com
Branch: androidx-main
commit b76fc769718910bb2630c5e8c951d50df38e4d58
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 02 09:22:58 2021
Bump nav-compose nav dependency to 2.3.4
Making nav-compose depend on navigation-runtime 2.3.4 for a fix to no-op
when setting the same ViewModelStore.
RelNote: "Navigation Compose now depends on Navigation version 2.3.4
which includes the fix for attempting to set the same ViewModelStore
object after the graph has been set."
Test: NavHostTest
Bug: 177825470
Change-Id: I65c24fcd5674c1ac72715c612854aac62c2eda88
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
jb...@google.com
Now that Navigation compose depends on navigation-runtime 2.3.4, you can use the navigation-compose 1.0.0-SNAPSHOT with buildId 7179952.
Description
Android Studio Build: AF4
This happens when using nested navigation
val navController = rememberNavController()
NavHost(navController = navController) {
navigation {
something(navController) {
}}}
and in NavGraphBuilder.something:
composable{
onCommit(onboardingComplete) {
if (!onboardingComplete) {
navController.navigate(MainDestinations.ONBOARDING_ROUTE)
}
}}
Commenting this line out yields no crashes and navController.navigate() is used in many other places.
Not sure if it has to do with nested nav, but it worked fine with two nested navhosts.
I've uploaded a fork of Owl where this happens:
Crash in: Owl/app/src/main/java/com/example/owl/ui/courses/Courses.kt