Status Update
Comments
il...@google.com <il...@google.com>
jb...@google.com <jb...@google.com> #2
Oh I forgot to mention that I thought it might be connected to this issue:
an...@google.com <an...@google.com> #3
Please provide a minimal sample project along with the minimal steps to recreate the issue in the project.
jb...@google.com <jb...@google.com> #4
Sorry for the delay. I got a working example here:
I poked into it a little bit and it seems to be connected to
Steps to reproduce:
- Navigate from Second Fragment to Child nav graph (with non-nullable parameters).
- Navigate to Third fragment using SafeArgs and the app crashes.
Crash log:
Process: cz.dels.issues, PID: 1743
java.lang.NullPointerException: null cannot be cast to non-null type kotlin.Long
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:352)
at androidx.navigation.NavType$Companion$LongType$1.get(NavType.kt:342)
at androidx.navigation.NavArgument.verify(NavArgument.kt:76)
at androidx.navigation.NavDestination.addInDefaultArgs(NavDestination.kt:502)
at androidx.navigation.NavController.addEntryToBackStack(NavController.kt:1865)
at androidx.navigation.NavController.addEntryToBackStack$default(NavController.kt:1813)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1721)
at androidx.navigation.NavController$navigate$4.invoke(NavController.kt:1719)
at androidx.navigation.NavController$NavControllerNavigatorState.push(NavController.kt:287)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:246)
at androidx.navigation.fragment.FragmentNavigator.navigate(FragmentNavigator.kt:162)
at androidx.navigation.NavController.navigateInternal(NavController.kt:260)
at androidx.navigation.NavController.navigate(NavController.kt:1719)
at androidx.navigation.NavController.navigate(NavController.kt:1545)
at androidx.navigation.NavController.navigate(NavController.kt:1472)
at androidx.navigation.NavController.navigate(NavController.kt:1930)
at cz.dels.issues.SecondFragment.onViewCreated$lambda-0(SecondFragment.kt:38)
at cz.dels.issues.SecondFragment.$r8$lambda$XDYnOS_cYrafiNQ5rcCu1WCn0IE(Unknown Source:0)
at cz.dels.issues.SecondFragment$$ExternalSyntheticLambda0.onClick(Unknown Source:2)
Note: If in step 2 SaveArgs is not used then navigation works correctly. More information is here:
an...@google.com <an...@google.com> #5
Ups a typo: Navigate from Second First Fragment to Child nav graph (with non-nullable parameters).
Note: sorry for the spam but I am not able to edit my own comment.
jb...@google.com <jb...@google.com> #6
This has been fixed and will be available in navigation 2.6.0-alpha08
co...@gmail.com <co...@gmail.com> #7
Branch: androidx-main
commit 6b358154b794a0456b089ac8e548bfb830dd6c22
Author: Clara Fok <clarafok@google.com>
Date: Tue Mar 14 17:56:12 2023
Fix missing non-nullable arg when rebuilding hierarchy
When navigating with NavDirections, args is populated with an empty bundle. This causes issue when we rebuild parent hierarchy while adding a new entry to NavBackStack. If the Entry being rebuilt contains a non-nullalbe arg, i.e. Long, this empty bundle will cause an exception.
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 249988437
Change-Id: I5c8ce739ad9a3428c8a8de13eae391bfff0db5df
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
an...@google.com <an...@google.com> #8
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.navigation:navigation-runtime:2.6.0-alpha08
ja...@google.com <ja...@google.com> #9
jb...@google.com <jb...@google.com> #10
Currently working on a potential fix in aosp/1591051. Do you have an updated version of the app that uses the latest compose? If so I could check if that fix addresses your use case.
As far as work arounds, to avoid the crash you can clear the back stack when the NavHost is disposed by adding
onDispose {
while (navController.popBackStack()) { }
}
ap...@google.com <ap...@google.com> #11
Branch: androidx-main
commit e2280407cf218dd031a8f74dba2b4d709fc3e826
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon Mar 01 11:43:16 2021
No-op for same ViewModelStore and LifecycleOwner
When attempting to setViewModelStore or setLifecycleOwner if the
parameter passed in is the same as the one already set on the
NavController, the call should be a no-op.
RelNote: "Calling setViewModelStore or setLifecycleOwner with the same
object that has already been set will now be a no-op"
Test: NavControllerTest
Bug: 177825470
Change-Id: Idf491fa68c0771dd617832cefe4c03e8ea85dae7
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
jb...@google.com <jb...@google.com> #12
This has been fixed internally and will be released as part of the Navigation 2.3.4
version.
You can verify this by following the snapshot instructions with build id 7177928
and switching your navigation dependency to 2.4.0-SNAPSHOT
. Note that this will need to be an explicit dependency on navigation-runtime
in addition to the dependency on navigation-compose
.
ap...@google.com <ap...@google.com> #13
Branch: androidx-main
commit b76fc769718910bb2630c5e8c951d50df38e4d58
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Mar 02 09:22:58 2021
Bump nav-compose nav dependency to 2.3.4
Making nav-compose depend on navigation-runtime 2.3.4 for a fix to no-op
when setting the same ViewModelStore.
RelNote: "Navigation Compose now depends on Navigation version 2.3.4
which includes the fix for attempting to set the same ViewModelStore
object after the graph has been set."
Test: NavHostTest
Bug: 177825470
Change-Id: I65c24fcd5674c1ac72715c612854aac62c2eda88
M navigation/navigation-compose/build.gradle
M navigation/navigation-compose/src/androidTest/java/androidx/navigation/compose/NavHostTest.kt
jb...@google.com <jb...@google.com> #14
Now that Navigation compose depends on navigation-runtime 2.3.4
, you can use the navigation-compose
1.0.0-SNAPSHOT
with buildId 7179952
.
Description
Android Studio Build: AF4
This happens when using nested navigation
val navController = rememberNavController()
NavHost(navController = navController) {
navigation {
something(navController) {
}}}
and in NavGraphBuilder.something:
composable{
onCommit(onboardingComplete) {
if (!onboardingComplete) {
navController.navigate(MainDestinations.ONBOARDING_ROUTE)
}
}}
Commenting this line out yields no crashes and navController.navigate() is used in many other places.
Not sure if it has to do with nested nav, but it worked fine with two nested navhosts.
I've uploaded a fork of Owl where this happens:
Crash in: Owl/app/src/main/java/com/example/owl/ui/courses/Courses.kt