Lifecycle should not allow moving from INITIALIZED to DESTROYED [177924329]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Jan 19, 2021 08:04PM

If you add an observers to a Lifecycle object and attempt to move that Lifecycle.State from INITIALIZED to DESTROYED, the following error will be thrown:

java.lang.IllegalStateException: no event down from INITIALIZED

If there is no observer, then the lifecycle state is moved without any error.

Moving the Lifecycle.State from INITIALIZED to DESTROYED should be consistent whether or not there is an observer on the Lifecycle.

Comments

il...@google.com <il...@google.com> Nov 18, 2021 10:12PM

Status: New

jb...@google.com <jb...@google.com> Feb 4, 2022 12:34AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Feb 7, 2022 02:27PM

deleted

il...@google.com <il...@google.com> #3Feb 7, 2022 06:05PM

Marked as fixed.

https://www.google.com

ad...@gmail.com <ad...@gmail.com> #4Feb 28, 2022 03:11PM

targetPackageOnly needs to be updated to understand process_tracks in addition to thread_tracks. E.g. could union the current result with one around process_tracks, something like:

select * from slice
    inner join process_track on slice.track_id = process_track.id
    inner join process USING(upid)
where slice.id=23647

l....@gmail.com <l....@gmail.com> #5Mar 31, 2022 09:02AM

I was thinking, since this is already in beta03, should we treat it as a bug and not addition to 1.3?

il...@google.com <il...@google.com> #6Mar 31, 2022 11:28PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3bfcb889231d3254cf9e8db8df0c2a06f58c152a
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Tue Apr 02 14:14:17 2024

TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.

* TraceSectionMetric now additionally looks at Perfetto `process_track`s when looking at named slices.

Test: PerfettoTraceProcessorTest
Fixes: 300434906
Relnote: TraceSectionMetric now supports slices created using `Trace.{begin|end}AsyncSection`.
Change-Id: I91b326e121fcca4b3ce8f65381eea87de796cdd1

M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/perfetto/PerfettoTraceProcessorTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/perfetto/PerfettoTraceProcessor.kt

https://android-review.googlesource.com/3023506