Fixed
Status Update
Comments
ra...@google.com <ra...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 9e27da5f1e93c7bc7fd1e14101c98dbd6718a22d
Author: Ralston Da Silva <ralu@google.com>
Date: Tue Jan 19 18:47:38 2021
Rename Key.DPadUp to Key.DirectionUp
The DPadUp/DPadDown/DPadLeft/DPadRight are used on the desktop to represent arrow keys.
This CL renames these values to a more neutral word instead of DPad.
It also moves the kDoc comments to the actual files as these are the ones that show up in Android Studio.
Bug: 177954892
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.CustomFocusTraversalTest
Relnote: Key.DPadUp is deprecated. Use Key.DirectionUp instead.
Relnote: Key.DPadDown is deprecated. Use Key.DirectionDown instead.
Relnote: Key.DPadLeft is deprecated. Use Key.DirectionLeft instead.
Relnote: Key.DPadRight is deprecated. Use Key.DirectionRight instead.
Relnote: Key.DPadCenter is deprecated. Use Key.DirectionCenter instead.
Relnote: Key.DPadUpLeft is deprecated. Use Key.DirectionUpLeft instead.
Relnote: Key.DPadDownLeft is deprecated. Use Key.DirectionDownLeft instead.
Relnote: Key.DPadUpRight is deprecated. Use Key.DirectionUpRight instead.
Relnote: Key.DPadDownRight is deprecated. Use Key.DirectionDownRight instead.
Change-Id: Iab3358b1d0172731601009df117974ca02d2e5a6
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/CustomFocusTraversalTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/key/Key.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/key/Key.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/key/Key.kt
https://android-review.googlesource.com/1555034
Branch: androidx-main
commit 9e27da5f1e93c7bc7fd1e14101c98dbd6718a22d
Author: Ralston Da Silva <ralu@google.com>
Date: Tue Jan 19 18:47:38 2021
Rename Key.DPadUp to Key.DirectionUp
The DPadUp/DPadDown/DPadLeft/DPadRight are used on the desktop to represent arrow keys.
This CL renames these values to a more neutral word instead of DPad.
It also moves the kDoc comments to the actual files as these are the ones that show up in Android Studio.
Bug: 177954892
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.CustomFocusTraversalTest
Relnote: Key.DPadUp is deprecated. Use Key.DirectionUp instead.
Relnote: Key.DPadDown is deprecated. Use Key.DirectionDown instead.
Relnote: Key.DPadLeft is deprecated. Use Key.DirectionLeft instead.
Relnote: Key.DPadRight is deprecated. Use Key.DirectionRight instead.
Relnote: Key.DPadCenter is deprecated. Use Key.DirectionCenter instead.
Relnote: Key.DPadUpLeft is deprecated. Use Key.DirectionUpLeft instead.
Relnote: Key.DPadDownLeft is deprecated. Use Key.DirectionDownLeft instead.
Relnote: Key.DPadUpRight is deprecated. Use Key.DirectionUpRight instead.
Relnote: Key.DPadDownRight is deprecated. Use Key.DirectionDownRight instead.
Change-Id: Iab3358b1d0172731601009df117974ca02d2e5a6
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/focus/CustomFocusTraversalTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/key/Key.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/focus/FocusModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/key/Key.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/key/Key.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 20230ac1b96f0256d565da22fef96c53de0b194f
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Jan 20 10:47:13 2021
Deprecate items I missed in aosp/1555034
There were some functions that were deprecated in the expects class,
but not in the actual class. This CL fixes that.
Bug: 177954892
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.CustomFocusTraversalTest
Relnote: N/A
Change-Id: Idc5e757f717911b5695669e7fa536de9b7fb13bc
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/key/Key.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/key/Key.kt
https://android-review.googlesource.com/1555360
Branch: androidx-main
commit 20230ac1b96f0256d565da22fef96c53de0b194f
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Jan 20 10:47:13 2021
Deprecate items I missed in aosp/1555034
There were some functions that were deprecated in the expects class,
but not in the actual class. This CL fixes that.
Bug: 177954892
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.focus.CustomFocusTraversalTest
Relnote: N/A
Change-Id: Idc5e757f717911b5695669e7fa536de9b7fb13bc
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/key/Key.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/key/Key.kt
Description