androidx.compose.foundation.layout.Box() Modifier.paint() never calls drawContent() [178201337]

Fixed

Bug

Status Update

No update yet.

Description

jn...@google.com

created issue #1

Jan 22, 2021 06:02PM

Jetpack Compose release version: 1.0.0-alpha10

Android Studio 4.2 Beta 1 Build #AI-202.7660.26.42.6987402, built on November 21, 2020 Runtime version: 11.0.8+0-b944-P17168821 amd64 VM: OpenJDK 64-Bit Server VM by N/A Linux 5.7.17-1rodete5-amd64 GC: G1 Young Generation, G1 Old Generation Memory: 5120M Cores: 72 Registry: external.system.auto.import.disabled=true, ide.index.image.max.size=0, caches.indexerThreadsCount=24 Non-Bundled Plugins: com.intellij.marketplace, com.thoughtworks.gauge, org.jetbrains.kotlin, org.intellij.plugins.markdown Current Desktop: X-Cinnamon

Modifier.paint() does not call drawContent().

Steps to Reproduce:

Create a Box with a Modifier.paint(). The contents of the box will not be drawn.

@Composable
fun TestBoxPaintDoesNotPaintContents() {
  val imageBackground = imageResource(id = R.drawable.backgroundimage1)
  Box (modifier = Modifier.padding(12.dp).paint(painter = ImagePainter(image = imageBackground))) {
    Text(text = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.",
         overflow = TextOverflow.Ellipsis)
  }
}

Run on a watch or a phone emulator
Observe that the paint() is called and renders the box background, but the contents of the Box(), i.e. the text is not rendered on top of the image.

Comments

ma...@google.com <ma...@google.com> #2Jun 14, 2021 01:47PM

With this change https://android-review.googlesource.com/c/platform/frameworks/support/+/1675367 we are very close to supporting API 21.

The things we need to tackle after this CL lands are:

Follow up on this CL (https://android-review.googlesource.com/c/platform/external/perfetto/+/1680145). The binaries checked in, include this change but currently its failing presubmits because of a compiler warning. Something primiano@ is currently looking into.
Expand trace_processor_shells ABI support to include arm, and x86_64. Remove the explicit checks for API Q.
Remove the use of @RequiresApi(29) in MacrobenchmarkRule / Lower it to API 21, andexplicit checks for API Q.
verifyTraceEnabled(...) does seem to cause issues on lower versions of the platform. Something we need to investigate further. This does not happen consistently though.
Fix our perfetto trace configs. There are options that are unsupported on older versions of the platform.
M, and N dont support several ART compilation modes. No op on them.

an...@google.com <an...@google.com> Jun 14, 2021 02:53PM

Assigned to nj...@google.com.

ap...@google.com <ap...@google.com> #3Jul 17, 2021 12:34AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 22fe26bc907af50d557254d406eb38469a7bb81b
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Fri Apr 16 11:15:58 2021

Add unbundled perfetto support.

With this change, we are much closer in bringing Macrobenchmarks to API 21.

The things we need to tackle after this CL lands are:

* Follow up on this CL (

https://android-review.googlesource.com/c/platform/external/perfetto/+/1680145).
The binaries checked in, include this change but currently its failing presubmits because of a compiler warning.
Something primiano@ is currently looking into.
* Expand trace_processor_shells ABI support to include arm, and x86_64.
Remove the explicit checks for API Q.
* Remove the use of @RequiresApi(...) in MacrobenchmarkRule, and explicit checks for API Q.
* verifyTraceEnabled(...) does seem to cause issues on lower versions of the platform. Something we need to investigate further.
This does not happen consistently though.
* Fix our perfetto trace configs. There are options that are unsupported on older versions of the platform.
* M, and N dont support several ART compilation modes. No op on them.

Test: PerfettoCaptureTest is now parameterized
Bug:

b/183129298

Change-Id: I888fa15e02acc4f99fbf548722a11a9953988357

M benchmark/macro/build.gradle
M benchmark/macro/src/androidTest/java/androidx/benchmark/macro/perfetto/PerfettoCaptureTest.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCapture.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoCaptureWrapper.kt
M benchmark/macro/src/main/java/androidx/benchmark/macro/perfetto/PerfettoHelper.kt

https://android-review.googlesource.com/1675367

Issue 178201337

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> #2Jun 14, 2021 01:47PM

an...@google.com <an...@google.com> Jun 14, 2021 02:53PM

ap...@google.com <ap...@google.com> #3Jul 17, 2021 12:34AM

Add comment

Issue metadata