androidx.compose.foundation.layout.Box() Modifier.paint() never calls drawContent() [178201337]

Fixed

Bug

Status Update

No update yet.

Description

jn...@google.com

created issue #1

Jan 22, 2021 06:02PM

Jetpack Compose release version: 1.0.0-alpha10

Android Studio 4.2 Beta 1 Build #AI-202.7660.26.42.6987402, built on November 21, 2020 Runtime version: 11.0.8+0-b944-P17168821 amd64 VM: OpenJDK 64-Bit Server VM by N/A Linux 5.7.17-1rodete5-amd64 GC: G1 Young Generation, G1 Old Generation Memory: 5120M Cores: 72 Registry: external.system.auto.import.disabled=true, ide.index.image.max.size=0, caches.indexerThreadsCount=24 Non-Bundled Plugins: com.intellij.marketplace, com.thoughtworks.gauge, org.jetbrains.kotlin, org.intellij.plugins.markdown Current Desktop: X-Cinnamon

Modifier.paint() does not call drawContent().

Steps to Reproduce:

Create a Box with a Modifier.paint(). The contents of the box will not be drawn.

@Composable
fun TestBoxPaintDoesNotPaintContents() {
  val imageBackground = imageResource(id = R.drawable.backgroundimage1)
  Box (modifier = Modifier.padding(12.dp).paint(painter = ImagePainter(image = imageBackground))) {
    Text(text = "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.",
         overflow = TextOverflow.Ellipsis)
  }
}

Run on a watch or a phone emulator
Observe that the paint() is called and renders the box background, but the contents of the Box(), i.e. the text is not rendered on top of the image.

Comments

ma...@google.com <ma...@google.com> #2Jun 14, 2021 01:47PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 03da1e41b1a80255f502fe91b35e3e8f5c3af530
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Jul 13 16:58:06 2020

Add Modifier.FocusObserver

Add a modifier that allows a parent composable to observe the focus state of it's child.

Bug: 160924455, 160923326
Relnote: Added a modifier to observe focus state change.
Test: Launched demo app
Change-Id: I05866104c323317f41f43ce1c286236b7e344d4b

M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/DelegatingLayoutNodeWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/InnerPlaceable.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNodeWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusModifier2.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusObserverModifier.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/ModifiedFocusObserverNode.kt

https://android-review.googlesource.com/1362061

an...@google.com <an...@google.com> Jun 14, 2021 02:53PM

Assigned to nj...@google.com.

ap...@google.com <ap...@google.com> #3Jul 17, 2021 12:34AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 58b99f068004fee3861dfcce7b09d33c5fe4a891
Author: Nader Jawad <njawad@google.com>
Date: Fri Jul 16 15:36:08 2021

Make Modifier.paint behave like Modifier.drawBehind

Relnote: "In order to better support chaining of
draw modifiers, make sure the Modifier.paint implementation
calls drawsContent.
Previously Modifier.paint was expected to a leaf node in
the chain of Modifiers, however, by doing so it prevents
it from being configured on a composable container (ex. box)
or adding additional decorations on top such as
Modifier.paint().border(). By having Modifier.paint
call drawContent after drawing the contents of the given
painter, we have better behavior consistency in behavior
with the modifier pattern."

Fixes: 178201337
Fixes: 186213275
Test: Added test to PainterModifierTest
Change-Id: Ibb2a7ae54a86643ba4fc1604ce39df7477ab66f0

M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/draw/PainterModifierTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/draw/PainterModifier.kt

https://android-review.googlesource.com/1770022

Issue 178201337

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> #2Jun 14, 2021 01:47PM

an...@google.com <an...@google.com> Jun 14, 2021 02:53PM

ap...@google.com <ap...@google.com> #3Jul 17, 2021 12:34AM

Add comment

Issue metadata