Move TextInputService.notifyFocusedRectangle capability to higher level [178211874]

Fixed

Feature Request

Status Update

No update yet.

Description

si...@google.com

created issue #1

Jan 22, 2021 07:29PM

Last week I talked with Adam and Leland as well. Adam suggested that it is a candidate capability in Layout system.

What the function does is:
- calls requestRectangle on View.

Therefore it is something that we can bubble up from current node to parents and then the View system until the provided area is visible on screen.

Not sure how compose scrollers would react to this and if it is possible.

Related tickets

b/158077456

b/154101484

b/174779644

Comments

si...@google.com <si...@google.com> #2Jan 22, 2021 07:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit bbe1d83f1c87167b0da0104a8cc997db7b00f498
Author: Anastasia Soboleva <soboleva@google.com>
Date: Mon Sep 25 09:38:18 2023

Add Uspecified to Hyphens, LineBreak, TextAlign, TextDirection

ParagraphStyle and TextStyle takes these as non-null params in ctors, copy and merge to avoid boxing.

Deprecated getTextAlign and similar public getters nullable for binary compat. Introduced non-null counterparts that compile into primitives.

Before:
5,150 ns 5 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.draw[size=2, spanCount=4]
18,965 ns 99 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.recomposeOnly[size=2, spanCount=4]
44,769 ns 208 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.recomposeMeasureLayout[size=2, spanCount=4]

After:
5,265 ns 5 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.draw[size=2, spanCount=4]
19,054 ns 99 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.recomposeOnly[size=2, spanCount=4]
44,617 ns 201 allocs Trace Method Trace EMULATOR_AllAppsWithSpans.recomposeMeasureLayout[size=2, spanCount=4]

Before:
159,575 ns 647 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.toggleRectangleColor_measure[10]
138,596 ns 580 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.layout[10]
191,924 ns 715 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.first_measure[10]
1,653,166 ns 6220 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.toggleRectangleColor_measure[100]
1,246,603 ns 5490 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.layout[100]
1,529,656 ns 6859 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.first_measure[100]

After:
177,292 ns 597 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.toggleRectangleColor_measure[10]
139,119 ns 550 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.layout[10]
186,741 ns 645 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.first_measure[10]
1,642,789 ns 5500 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.toggleRectangleColor_measure[100]
1,352,991 ns 5231 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.layout[100]
1,570,829 ns 6159 allocs Trace Method Trace EMULATOR_TextInColumnBenchmark.first_measure[100]

Test: ui:ui-text:test, ui:ui-text:cC
Test: benchmarks
Bug: 299490814

Relnote: "Introduced a special Unspecified value for TextAlign, TextDirection, Hyphens and LineBreak fields of the ParagraphTextStyle to replace “null”. Because these classes are inline classes, by replacing nullable with the Unspecified, we avoid primitive type boxing.
Constructors, getters and other methods in TextStyle and Paragraph style were update to accept the mentioned parameters as non-null types."

Change-Id: I4197ea85db556846ecad27ca8f561955e2370951

M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Text.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Text.kt
M compose/ui/ui-inspection/src/androidTest/java/androidx/compose/ui/inspection/inspector/ParameterFactoryTest.kt
M compose/ui/ui-text/api/current.ignore
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/restricted_current.ignore
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/AndroidParagraphTest.kt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/AndroidParagraphTextDirectionTest.kt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/MultiParagraphIntegrationTextDirectionTest.kt
M compose/ui/ui-text/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/ParagraphIntegrationTextDirectionTest.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/AndroidParagraph.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/AndroidParagraphIntrinsics.android.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/style/LineBreak.android.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/ParagraphStyleTest.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/TextStyleLayoutAttributesTest.kt
M compose/ui/ui-text/src/androidUnitTest/kotlin/androidx/compose/ui/text/TextStyleTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/MultiParagraphIntrinsics.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/ParagraphStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/SpanStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TextStyle.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/Hyphens.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/LineBreak.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/TextAlign.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/TextDirection.kt
M compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/platform/SkiaParagraph.skiko.kt
M compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/style/LineBreak.skiko.kt
M tv/tv-material/src/main/java/androidx/tv/material3/Text.kt
M wear/compose/compose-material-core/src/main/java/androidx/wear/compose/materialcore/Text.kt

https://android-review.googlesource.com/2763568

si...@google.com <si...@google.com> Jan 22, 2021 11:10PM

Reassigned to se...@google.com.

si...@google.com <si...@google.com> #3Jan 25, 2021 06:27PM

Reassigned to mo...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit e21f04493c5ee666dc8fc472ff3e085e4ab88945
Author: Anastasia Soboleva <soboleva@google.com>
Date: Mon Oct 09 12:16:50 2023

Replace TextAlign? parameter with TextAlign in tv Text

Since tv's Text is still experimental, we better replace nullable with non-null to avoid primitive type boxing

Bug: 299490814
Test: TextTest
Relnote: "TV Text component's TextAlign parameter is now non-null"

Change-Id: Ib73b136b5d997de3869ca63e7c6dcad5e513ec1e

M tv/tv-material/api/current.txt
M tv/tv-material/api/restricted_current.txt
M tv/tv-material/src/main/java/androidx/tv/material3/Text.kt

https://android-review.googlesource.com/2775146

mo...@google.com <mo...@google.com> #4Jan 25, 2021 06:56PM

Reassigned to ra...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.6.0-alpha08
androidx.compose.material:material-android:1.6.0-alpha08
androidx.compose.material:material-desktop:1.6.0-alpha08
androidx.compose.material3:material3:1.2.0-alpha10
androidx.compose.material3:material3-android:1.2.0-alpha10
androidx.compose.material3:material3-desktop:1.2.0-alpha10
androidx.compose.ui:ui-text:1.6.0-alpha08
androidx.compose.ui:ui-text-android:1.6.0-alpha08
androidx.compose.ui:ui-text-desktop:1.6.0-alpha08
androidx.wear.compose:compose-material-core:1.3.0-alpha08

si...@google.com <si...@google.com> #5Jan 25, 2021 07:03PM

George, is this correct: You think this should not be a layout API but focus API?

The reason why I thought it is a layout API is the fact that it is a layout related View API in android independent of the focus management.

It is being used by focus on EditText, but it also is not 1-1 related to focus. For example it is possible that as a developer I'd like to show different components for a tutorial as the user clicks on next on my tutorial (I guess this was an example given on the chat)

si...@google.com <si...@google.com> #6Jan 25, 2021 07:31PM

FYI: Happy to implement this one if you can guide me on where to start, or how to do it.

mo...@google.com <mo...@google.com> #7Jan 25, 2021 07:38PM

Reassigned to ma...@google.com.

OK, I have to admit that I made a mistake while reading. I saw the platform prefix and in the top-left of that page and thought this was a View method that we were overriding.

Stream of consciousness here:

It looks like notifyFocusedRect() is intended to call requestRectangleOnScreen(). This is a layout system API, not a focus system API.

I think we have some of what you need already in public API. What you're looking for is the bounding box of a Layout, right? To get this, look at LayoutCoordinates.boundsInRoot().

I think the thing you're looking for is the actual requestRectangleOnScreen() equivalent, right? I don't know if we want to expose it as an arbitrary rectangle or if we want to expose it as applying to an entire LayoutCoordinates. My initial thought is that any LayoutCoordinates is sufficient and an easier API to work with. I would recommend that we start with that API and see how much need there is to request an arbitrary rectangle on the screen.

I haven't looked at the implementation of requestRectangleOnScreen() but I imagine that there is a lot of setting scroll positions. We will have to set scroll positions of scrollables in the hierarchy. There's currently no way for a scrollable to interact with the layout system in a way that allows the layout system to provide feedback to scrollable.

Matvei, do you have any suggestions here? Can the layout system poke a scrollable to change its scroll position?

If it isn't possible (my initial thought), then we have to interact at a higher level of abstraction, using the nested scrolling interface to bring a rectangle on screen. Maybe something like this:

fun NestedScrollDispatcher.requestBringOnScreen(coordinates: LayoutCoordinates)

It looks like the nested scrolling is implemented in NestedScrollDelegatingWrapper, so it may be possible to have:

fun LayoutCoordinates.requestBringOnScreen()

mo...@google.com <mo...@google.com> #8Jan 25, 2021 07:39PM

Assigning to Matvei for his input.

se...@google.com <se...@google.com> #9Apr 9, 2021 03:34AM

Bumping this ticket as it's coming up very regularly in #Compose chat.

Use cases that developers are hitting regularly.

TextField in a LazyColumn is not visible after keyboard shows, even if scrolling would allow it to be visible
TextField in a scrollable Column is not visible after keyboard shows, even if scrolling would allow it to be visible

se...@google.com <se...@google.com> #10Apr 9, 2021 03:39AM

One workaround (in app code) is to save the layout position for the TextField then manually scroll a ScrollState.

ma...@google.com <ma...@google.com> #11Apr 14, 2021 01:46PM

Coming back to this to give me 5 cents.

Modifier.scrollable itself doesn't have any notion of layout at all, so I'm unsure if that would be the right place for it. Thing to node is that we also need to provide a proper nestedscroll support (+ account for nested scroll as well, as you want your toolbar to collapse if the textField is below the soft input, don't you?).

It seems like we would need to account for that in the scrollable implementations, e.g Modifier.verticalScroll or LazyColumn, as they also might want to process it differently. Some bits might live in the Modifier.scrollable as well, but it's mostly a layout thing I suppose.

Another alternative: could it be possible to utilise semantics for this purpose? I don't know how idiomatic it would be but it seems like it is somewhat related. WE could basically ask whatever container to scroll to the bounds (which we could retrieve from the layout node) and the scroll bit will just work out of the box if the semantics are set right.

ra...@google.com <ra...@google.com> Apr 17, 2021 12:14AM

Accepted by ra...@google.com.

ma...@google.com <ma...@google.com> #12Apr 20, 2021 11:00AM

Ralston, let me know if you need any help or input from the scrolling side! Thanks!

ap...@google.com <ap...@google.com> #13May 13, 2021 06:53AM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit 421a738e446c6118de69765225a1508bdfd39372
Author: Ralston Da Silva <ralu@google.com>
Date: Wed May 05 06:33:28 2021

Golden images for RelocationRequester Modifier

This CL adds snapshots for the RelocationRequesterModifierTest

Bug: 178211874
Change-Id: I337d81b2176be1da4b7645b941c48c92e0d3075e
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.layout.RelocationRequesterModifierTest

A compose/ui/ui/bringIntoParentBounds_blueBoxBottom_cuttlefish.png
A compose/ui/ui/bringIntoParentBounds_blueBoxCenterHorizontal_cuttlefish.png
A compose/ui/ui/bringIntoParentBounds_blueBoxCenterVertical_cuttlefish.png
A compose/ui/ui/bringIntoParentBounds_blueBoxLeft_cuttlefish.png
A compose/ui/ui/bringIntoParentBounds_blueBoxRight_cuttlefish.png
A compose/ui/ui/bringIntoParentBounds_blueBoxTop_cuttlefish.png
A compose/ui/ui/bringIntoParentBounds_blueBox_cuttlefish.png
A compose/ui/ui/bringIntoParentBounds_grayRectangleHorizontal_cuttlefish.png
A compose/ui/ui/bringIntoParentBounds_grayRectangleVertical_cuttlefish.png

https://android-review.googlesource.com/1697025

ap...@google.com <ap...@google.com> #14May 13, 2021 06:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit bd6db32649c6060ddead0d1f7e55636e60c9ff61
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Apr 19 17:54:18 2021

Relocation Modifier

This is a modifier that can be used to bring an item into view by requesting that
all its scrollable parents scroll so that this item is visible.

Bug: 178211874
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.layout.RelocationRequesterModifierTest
Relnote: Added Experimental Modifier.relocate()
Change-Id: I48322e5f84f5d688f92c7a397e9b1328b3824f63

M compose/ui/ui/api/1.0.0-beta08.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta08.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta08.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/UiDemos.kt
A compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/scroll/BringIntoParentBoundsDemo.kt
A compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/RelocationSamples.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/RelocationRequesterModifierTest.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/RelocationRequester.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/RelocationRequesterModifier.kt

https://android-review.googlesource.com/1679892

ap...@google.com <ap...@google.com> #15May 25, 2021 10:50PM

Project: platform/frameworks/support
Branch: androidx-main

commit 42303ba13af7818755606f2a3ebf931914b2b50e
Author: Ralston Da Silva <ralu@google.com>
Date: Thu May 20 15:12:54 2021

Bring item into View

This CL renames RelocationRequester.bringIntoParentBounds() to RelocationRequester.bringIntoView.
It also supports the use-case where they keyobard could be hiding the element, and brings
it into view by calling view.requestRectangleOnScreen.

Bug: 178211874
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.layout.RelocationRequesterModifierTest
Relnote: N/A
Change-Id: I4124888de3b67fda965372380b5a166406817ce1

M compose/ui/ui/api/public_plus_experimental_1.0.0-beta08.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/UiDemos.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/scroll/BringIntoViewDemo.kt
A compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/scroll/RequestRectangleOnScreeenDemo.kt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/RelocationSamples.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/RelocationRequesterModifierTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/RelocationRequester.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/RelocationRequesterModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.desktop.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt

https://android-review.googlesource.com/1715468

ni...@google.com <ni...@google.com> #16Jun 3, 2021 12:41AM

Bulk edit: This bug is currently marked as blocking Compose 1.0. Once rc01 is cut, all changes will need to go through our cherry-pick process.

If you intend to fix it in Compose 1.0, no action is needed except prioritizing finishing this work.

Otherwise, please remove this bug from the appropriate 1.0 hotlist (likely Jetpack Compose 1.0 (May 2021)) and add it to Post-1.0 (or not-yet-prioritized).

Thanks!

ra...@google.com <ra...@google.com> #17Jun 16, 2021 07:27PM

For this fix we need TextField to use RelocationRequester.bringIntoView() which is an experimental UI API, and it so it can't be fixed for Compose 1.0

ap...@google.com <ap...@google.com> #18Jul 1, 2021 06:00PM

Project: platform/frameworks/support
Branch: androidx-main

commit e40d3772b9a36196f94dfaef0483e3fc52951b53
Author: Ralston Da Silva <ralu@google.com>
Date: Fri Jun 04 18:02:01 2021

Implement bringIntoView

We initially tried to implement bringIntoView by making changes
to nested scroll. This CL adds a Modifier.onRelocationRequest
that responds to requests from Modifier.relocationRequester
more details at go/compose-bringIntoView

Bug: 178211874
Test: ./gradlew compose:ui:ui:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.layout.RelocationModifierTest
Relnote: Added experimental modifier to handle relocation requests.
Change-Id: I65a97bd7fca7271781efe31fcc9cb387e9857b51

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/UiDemos.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/scroll/BringIntoViewDemo.kt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/scroll/RequestRectangleOnScreeenDemo.kt
M compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/RelocationSamples.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/RelocationModifierTest.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/RelocationRequesterModifierTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/RelocationModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/RelocationRequester.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/RelocationRequesterModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/ModifiedRelocationNode.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/ModifiedRelocationRequesterNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopOwner.desktop.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt

https://android-review.googlesource.com/1737474

si...@google.com <si...@google.com> Nov 17, 2021 02:29AM

Reassigned to an...@google.com.

so...@google.com <so...@google.com> #19Jan 25, 2022 04:46PM

Reassigned to kl...@google.com.

I didn't realize Zach has got a fix for these, reassigning.

ap...@google.com <ap...@google.com> #20Feb 2, 2022 09:51PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a5c92f31181087df9a6a7100111d4248b94e75d4
Author: Zach Klippenstein <klippenstein@google.com>
Date: Fri Jan 28 12:36:11 2022

Change CoreTextField to use BringIntoViewRequester.

CoreTextField needs to ensure the cursor is in the visible bounds of all
scrollable parents, including the one in the text field itself.
Originally, it tried doing this by going through some of the text
service abstractions and ultimately calling
`View.requestRectangleOnScreen`. However, composable parents also need
to be aware of the request, so the correct way to do this is to use the
relatively recent `BringIntoViewRequester`. I'm not sure why all the
indirection through text services was done, it isn't necessary and
obscures the code, so I just made `CoreTextField` directly call
`BringIntoViewRequester.bringIntoView()`. This helps with

b/192043120

but doesn't completely fix it, due to

b/216842427

.

Bug:

b/192043120

Fixes:

b/178211874

Test: Tested manually.
Test: Refactored TextFieldDelegate unit tests to use the new code path:
./gradlew :compose:f:f:test
Relnote: "`notifyFocusedRect` methods in `TextInputSession` and
`TextInputService` are now deprecated and won't be called. Use
`BringIntoViewRequester` instead."

Change-Id: Ia4302c5f6ee79eec30a9f42c149da8775e1ed57e

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/foundation/foundation/benchmark/src/androidTest/java/androidx/compose/foundation/benchmark/text/TextFieldToggleTextTestCase.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/TextInputServiceAndroid.android.kt
A compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextFieldBringIntoViewTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldDelegate.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextInputService.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/text/TextFieldDelegateTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextInputServiceTest.kt
M compose/ui/ui-text/api/current.txt

https://android-review.googlesource.com/1959647

ap...@google.com <ap...@google.com> #21Feb 3, 2022 11:13PM

Project: platform/frameworks/support
Branch: androidx-main

commit b47ac54b27a3e77b40f672cbcd5a713f464a4d27
Author: Zach Klippenstein <klippenstein@google.com>
Date: Thu Feb 03 12:09:04 2022

Revert removing implementations of notifyFocusedRect.

The notifyFocusedRect methods on TextInputService and TextInputSession
were deprecated and had their implementations replaced by no-ops in the
change aosp/1959647. This was probably too aggressive, so this change
adds the old implementations back in but leaves them deprecated, in case
any third-party code was calling them. The implementations were actually
broken before, and this change doesn't try to fix them, it just restores
the previous broken behavior.

Discussion thread about revert:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1959647/comments/81f97bed_7f38e815

Bug:

b/192043120

Bug:

b/178211874

Test: Old tests restored.
Change-Id: I385749b629fd35b72bd148122ab1ec0f6d4ffa96

M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextInputService.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/TextInputServiceAndroid.android.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/TextInputServiceTest.kt

https://android-review.googlesource.com/1971363

da...@gmail.com <da...@gmail.com> #22Nov 23, 2022 12:35PM

Is there something that has to be done from the developer perspective for the textfield to scroll into view when the keyboard comes up to cover them?

Issue 178211874

Description

Issue summary

Comments

si...@google.com <si...@google.com> #2Jan 22, 2021 07:33PM

si...@google.com <si...@google.com> Jan 22, 2021 11:10PM

si...@google.com <si...@google.com> #3Jan 25, 2021 06:27PM

mo...@google.com <mo...@google.com> #4Jan 25, 2021 06:56PM

si...@google.com <si...@google.com> #5Jan 25, 2021 07:03PM

si...@google.com <si...@google.com> #6Jan 25, 2021 07:31PM

mo...@google.com <mo...@google.com> #7Jan 25, 2021 07:38PM

mo...@google.com <mo...@google.com> #8Jan 25, 2021 07:39PM

se...@google.com <se...@google.com> #9Apr 9, 2021 03:34AM

se...@google.com <se...@google.com> #10Apr 9, 2021 03:39AM

ma...@google.com <ma...@google.com> #11Apr 14, 2021 01:46PM

ra...@google.com <ra...@google.com> Apr 17, 2021 12:14AM

ma...@google.com <ma...@google.com> #12Apr 20, 2021 11:00AM

ap...@google.com <ap...@google.com> #13May 13, 2021 06:53AM

ap...@google.com <ap...@google.com> #14May 13, 2021 06:53AM

ap...@google.com <ap...@google.com> #15May 25, 2021 10:50PM

ni...@google.com <ni...@google.com> #16Jun 3, 2021 12:41AM

ra...@google.com <ra...@google.com> #17Jun 16, 2021 07:27PM

ap...@google.com <ap...@google.com> #18Jul 1, 2021 06:00PM

si...@google.com <si...@google.com> Nov 17, 2021 02:29AM

so...@google.com <so...@google.com> #19Jan 25, 2022 04:46PM

ap...@google.com <ap...@google.com> #20Feb 2, 2022 09:51PM

ap...@google.com <ap...@google.com> #21Feb 3, 2022 11:13PM

da...@gmail.com <da...@gmail.com> #22Nov 23, 2022 12:35PM

Add comment

Issue metadata