No has torch information [178251727]

Fixed

Bug

Status Update

No update yet.

Description

eu...@gmail.com

created issue #1

Jan 24, 2021 11:44PM

CAMERA VIEW VERSION 1.0.0-alpha20

DESCRIPTION: There is no method to get torch availability in CameraController. Also, the camera is completely encapsulated so I can not check hasTroch() method.

ADDITIONAL INFORMATION: I managed to do it with the next, but it is not something I would like to do further:

  private fun getTorchAvailability(cameraController: LifecycleCameraController): Boolean {
    val privateCameraField = cameraController::javaClass.get().superclass.getDeclaredField("mCamera")
    privateCameraField.isAccessible = true
    val camera =  privateCameraField.get(cameraController) as Camera?
    return camera?.cameraInfo?.hasFlashUnit() ?: false
  }

or something a bit safer but maybe not accurate:

  // Assume non face camera have torch and check system feature for the back camera
  private fun getTorchAvailability(cameraController: LifecycleCameraController): Boolean {
    return cameraController.cameraSelector == CameraSelector.DEFAULT_BACK_CAMERA &&
        requireContext().packageManager.hasSystemFeature(android.content.pm.PackageManager.FEATURE_CAMERA_FLASH)
  }

Comments

le...@google.com <le...@google.com> #2Jan 25, 2021 05:15AM

Thanks for reporting. We will look into the issue and update the status here.

eu...@gmail.com <eu...@gmail.com> #3Jan 25, 2021 05:00PM

Hi Thanks for reporting the issue. To have more context, can you help provide the following information ?

Can you show us how you configure the ImageCapture in the codes ?
Did you enable CameraX Extensions ?
so the occurrence rate is like 20%, right ?

er...@google.com <er...@google.com> Jan 25, 2021 05:30PM

Reassigned to le...@google.com.

le...@google.com <le...@google.com> #4Jan 26, 2021 03:17AM

Reassigned to xi...@google.com.

Thanks for your response.

Sure. I can provide more data.

ImageCapture.Builder builder = new ImageCapture.Builder();
builder.setCaptureMode(ImageCapture.CAPTURE_MODE_MINIMIZE_LATENCY);

if (!extensionAvailable) {
    builder.setBufferFormat(ImageFormat.YUV_420_888);
}

imageCapture = builder.build();

UseCaseGroup useCaseGroup = new UseCaseGroup.Builder()
                    .addUseCase(preview)
                    .addUseCase(imageCapture)
                    .setViewPort(viewPort)
                    .build();

cameraProvider.unbindAll();
camera = cameraProvider.bindToLifecycle(this, cameraSelector, useCaseGroup);

Yes, Extensions are enabled, which means that the code is not configuring the buffer format and therefore will use the JPEG format. If I disable the extensions, than the error disapears. But I think its more a jpeg format issue then an extension problem.
Yes, occurrence rate is 20%.

xi...@google.com <xi...@google.com> Jan 26, 2021 10:44PM

Accepted by xi...@google.com.

ap...@google.com <ap...@google.com> #5Feb 10, 2021 07:51AM

Thanks for the information! We will look into this.

xi...@google.com <xi...@google.com> Feb 10, 2021 05:13PM

Marked as fixed.