No has torch information [178251727]

Fixed

Bug

Status Update

No update yet.

Description

eu...@gmail.com

created issue #1

Jan 24, 2021 11:44PM

CAMERA VIEW VERSION 1.0.0-alpha20

DESCRIPTION: There is no method to get torch availability in CameraController. Also, the camera is completely encapsulated so I can not check hasTroch() method.

ADDITIONAL INFORMATION: I managed to do it with the next, but it is not something I would like to do further:

  private fun getTorchAvailability(cameraController: LifecycleCameraController): Boolean {
    val privateCameraField = cameraController::javaClass.get().superclass.getDeclaredField("mCamera")
    privateCameraField.isAccessible = true
    val camera =  privateCameraField.get(cameraController) as Camera?
    return camera?.cameraInfo?.hasFlashUnit() ?: false
  }

or something a bit safer but maybe not accurate:

  // Assume non face camera have torch and check system feature for the back camera
  private fun getTorchAvailability(cameraController: LifecycleCameraController): Boolean {
    return cameraController.cameraSelector == CameraSelector.DEFAULT_BACK_CAMERA &&
        requireContext().packageManager.hasSystemFeature(android.content.pm.PackageManager.FEATURE_CAMERA_FLASH)
  }

Comments

le...@google.com <le...@google.com> #2Jan 25, 2021 05:15AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

eu...@gmail.com <eu...@gmail.com> #3Jan 25, 2021 05:00PM

If I do the code above in parallel with the binding CameraController can I get any troubles? I will have two camera instances probably.

er...@google.com <er...@google.com> Jan 25, 2021 05:30PM

Reassigned to le...@google.com.

le...@google.com <le...@google.com> #4Jan 26, 2021 03:17AM

Reassigned to xi...@google.com.

If you are using the same CameraSelector for both CameraController.setCameraSelector() and CameraProvider.bindToLifecycle(), the Camera references should point to the same Camera instance. However, using CameraController and CameraProvider.bindToLifecycle() together is not a graceful means to obtain the Camera instance, so we will consider adding API to CameraController to get Camera or CameraInfo. Thanks again for your feedback.

xi...@google.com <xi...@google.com> Jan 26, 2021 10:44PM

Accepted by xi...@google.com.

ap...@google.com <ap...@google.com> #5Feb 10, 2021 07:51AM

Project: platform/frameworks/support
Branch: androidx-main

commit 6eb38682d674db3f5f6088ebf20303745559d327
Author: Xi Zhang <xizh@google.com>
Date: Sat Jan 30 09:57:42 2021

API change: add camera info getter to CameraController

As per feature request from developers, we are adding a CameraInfo getter to CameraController. The functionality of this method overlaps with #getZoomState() and #getTorchState(), but those methods also provide additional wrapping to always return the latest state regardless of the camera being selected.

Relnote: add a CameraInfo getter to CameraController.

Bug: 178251727
Test: manual test and ./gradlew bOS
Change-Id: Ib8138c44ebc17164d3bf91d4dbc684a0fe7a2728

M camera/camera-view/api/current.txt
M camera/camera-view/api/public_plus_experimental_current.txt
M camera/camera-view/api/restricted_current.txt
M camera/camera-view/src/main/java/androidx/camera/view/CameraController.java
M camera/integration-tests/viewtestapp/src/androidTest/java/androidx/camera/integration/view/CameraControllerFragmentTest.kt

https://android-review.googlesource.com/1565156

xi...@google.com <xi...@google.com> Feb 10, 2021 05:13PM

Marked as fixed.