NavInflater uses obtainAttributes which doesn't resolve theme attributes [178291654]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jan 24, 2021 11:37PM

Component used: Navigation Version used: 2.3.2 Devices/Android versions reproduced on: N/A

The current implementation of the nav graph inflater uses Resources::obtainAttributes, which doesn't deeply resolve theme attributes, meaning the following won't work:

// in attrs.xml
<attr name="transitionDefaultEnter" format="reference"/>
<attr name="transitionDefaultExit" format="reference"/>
<attr name="transitionDefaultPopEnter" format="reference"/>
<attr name="transitionDefaultPopExit" format="reference"/>

<attr name="transitionModalEnter" format="reference"/>
<attr name="transitionModalExit" format="reference"/>
<attr name="transitionModalPopEnter" format="reference"/>
<attr name="transitionModalPopExit" format="reference"/>

// in themes.xml
<item name="transitionDefaultEnter">@anim/slide_in_from_right</item>
<item name="transitionDefaultPopExit">@anim/slide_out_to_right</item>
...

// in nav_main.xml
<action
   android:id="@+id/someActionId"
   app:destination="@id/someDestination"
   app:enterAnim="?attr/transitionDefaultEnter"
   app:exitAnim="?attr/transitionDefaultExit"
   app:popEnterAnim="?attr/transitionDefaultPopEnter"
   app:popExitAnim="?attr/transitionDefaultPopExit" />

<action
   android:id="@+id/someOtherActionId"
   app:destination="@id/someModalScreenDestination"
   app:enterAnim="?attr/transitionModalEnter"
   app:exitAnim="?attr/transitionModalExit"
   app:popEnterAnim="?attr/transitionModalPopEnter"
   app:popExitAnim="?attr/transitionModalPopExit" />

Obviously this functionality would have a lot of use when it comes to "theming" an app's motion (and defining different "categories" of motion for an app) as well as being able to change animations more easily from one place in much the same was as changing colors or other theme attribute values.

Is there a reason the NavInflater hasn't been set up to resolve these attributes?

Comments

il...@google.com <il...@google.com> #2Jan 26, 2021 11:01PM

Assigned to jb...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3May 21, 2021 07:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit 44e5a4923964a338d5b7aac6392204b02852734e
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri May 21 11:49:49 2021

Use styledAttributes when inflating actions in xml

We currently don't resolve theme attributes when inflating an
action from xml. This causes the theme to be lost.

This change replaces the current resources.obtainAttributes call with
withStyledAttributes core method.

RelNote: "When inflating an `<action>` element, animation attributes can
use attributes pulled from your theme using the
`app:enterAnim=\"?attr/transitionEnter\"` syntax."
Test: all existing tests pass
Bug: 178291654

Change-Id: I07bc1fbfd65e0c36c0cd8f1210efc1e82810f3dd

M navigation/navigation-runtime/src/main/java/androidx/navigation/NavInflater.kt

https://android-review.googlesource.com/1715751

jb...@google.com <jb...@google.com> #4May 21, 2021 07:50PM

Marked as fixed.

This has been addressed internally and will be available in the Navigation 2.4.0-alpha02 release.

Issue 178291654

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Jan 26, 2021 11:01PM

ap...@google.com <ap...@google.com> #3May 21, 2021 07:34PM

jb...@google.com <jb...@google.com> #4May 21, 2021 07:50PM

Add comment

Issue metadata