Classcast exception with TextFieldValue [178312246]

Fixed

Bug

Status Update

No update yet.

Description

si...@google.com

created issue #1

Jan 24, 2021 04:27PM

"Getting ClassCastException for String to AnnotatedString when passing in String to TextFieldValue in Compose snapshot 7094152"

Possibly caused by this CL

Exception is

java.lang.ClassCastException: java.lang.String cannot be cast to androidx.compose.ui.text.AnnotatedString
        at androidx.compose.ui.text.input.TextFieldValue$Companion$Saver$2.invoke(TextFieldValue.kt:183)
        at androidx.compose.ui.text.input.TextFieldValue$Companion$Saver$2.invoke(TextFieldValue.kt)
        at androidx.compose.runtime.savedinstancestate.SaverKt$Saver$1.restore(Saver.kt:70)
        at androidx.compose.runtime.savedinstancestate.SavedInstanceStateKt$mutableStateSaver$2.invoke(SavedInstanceState.kt:87)
        at androidx.compose.runtime.savedinstancestate.SavedInstanceStateKt$mutableStateSaver$2.invoke(SavedInstanceState.kt)
        at androidx.compose.runtime.savedinstancestate.SaverKt$Saver$1.restore(Saver.kt:70)
        at androidx.compose.runtime.savedinstancestate.RememberSavedInstanceStateKt.rememberSavedInstanceState(RememberSavedInstanceState.kt:76)
        at androidx.compose.runtime.savedinstancestate.SavedInstanceStateKt.savedInstanceState(SavedInstanceState.kt:62)
        at ai.adagrad.gateguard.addvisitor.name.NameUiKt.NameUi(NameUi.kt:59)
        at ai.adagrad.gateguard.addvisitor.name.NameFragment$onCreateView$1$1$1$1.invoke(NameFragment.kt:90)
        at ai.adagrad.gateguard.addvisitor.name.NameFragment$onCreateView$1$1$1$1.invoke(NameFragment.kt)
        at androidx.compose.runtime.internal.ComposableLambda.invoke(ComposableLambda.kt:146)
        at androidx.compose.runtime.internal.ComposableLambda.invoke(ComposableLambda.kt)
        at androidx.compose.runtime.AmbientKt.Providers(Ambient.kt:188)
        at ai.adagrad.gateguard.addvisitor.name.NameFragment$onCreateView$1$1$1.invoke(NameFragment.kt:82)
        at ai.adagrad.gateguard.addvisitor.name.NameFragment$onCreateView$1$1$1.invoke(NameFragment.kt)
        at androidx.compose.runtime.internal.ComposableLambda.invoke(ComposableLambda.kt:146)
        at androidx.compose.runtime.internal.ComposableLambda.invoke(ComposableLambda.kt)
        at androidx.compose.runtime.AmbientKt.Providers(Ambient.kt:188)
        at androidx.compose.material.TextKt.ProvideTextStyle(Text.kt:246)
        at

Comments

si...@google.com <si...@google.com> #2Jan 25, 2021 04:33AM

Reassigned to an...@google.com.

I proposed this which I think it is better than the actual behavior, and could let the developers work with more room to be creative.

https://code.google.com/p/android/issues/detail?id=58318

si...@google.com <si...@google.com> Jan 25, 2021 06:17PM

Accepted by an...@google.com.

ap...@google.com <ap...@google.com> #3Jan 25, 2021 06:41PM

The presentation link doesn't work.

an...@google.com <an...@google.com> #4Jan 25, 2021 08:20PM

In Custom Notification Layouts section of the Notification API Guides, it states: "The height available for a custom notification layout depends on the notification view. Normal view layouts are limited to 64 dp, and expanded view layouts are limited to 256 dp". I guess it means the width is 512 dp and the height is 256 dp (if following the 2:1 aspect ratio)?

http://developer.android.com/guide/topics/ui/notifiers/notifications.html#CustomNotification

si...@google.com <si...@google.com> #5Jan 25, 2021 08:25PM

Here is the presentation:

http://commondatastorage.googleapis.com/io2012/presentations/live%20to%20website/105.pdf

si...@google.com <si...@google.com> #6Jan 25, 2021 08:50PM

https://code.google.com/p/android/issues/detail?id=58318http://developer.android.com/reference/android/app/Notification.BigPictureStyle.html#bigPicture(android.graphics.Bitmap)

si...@google.com <si...@google.com> #7Jan 25, 2021 08:52PM

Any update on this?

an...@google.com <an...@google.com> #8Jan 25, 2021 09:04PM

Thank you for your feedback. We assure you that we are doing our best to address all issues reported. For now, we will be closing the issue as won't fix obsolete. If this issue currently still exists, we request that you log a new issue along with the bug report here

https://goo.gl/TbMiIO and reference this bug for context.

si...@google.com <si...@google.com> #9Jan 25, 2021 09:59PM

Reassigned to si...@google.com.

Awesome, thanks again.

Message last modified on Jan 25, 2021 09:59PM

an...@google.com <an...@google.com> #10Jan 25, 2021 10:06PM

One more thought: given that we don't really support CharSequence in Compose. do we want to allow saving CharSequence? Maybe we should restrict it to Strings instead? what I mean is if user passes String - everything works, if user passes some CharSequence which is not String - throw an exception which asks to provide a custom Saver object. so the exact issue with AnnotatedString would be discovered earlier

si...@google.com <si...@google.com> #11Jan 25, 2021 10:23PM

given that we don't really support CharSequence in Compose. do we want to allow saving CharSequence?

If I understand you correctly, no, we don't need to allow saving CharSequence as long as we don't support it.

Maybe we should restrict it to Strings instead? what I mean is if user passes String - everything works, if user passes some CharSequence which is not String - throw an exception which asks to provide a custom Saver object. so the exact issue with AnnotatedString would be discovered earlier

"throw an exception which asks to provide a custom Saver object" sounds good to me. if the Saver does not know how to serialize a class then it is legit to throw an exception asking for help.

I do not know where we want to pay that cost (rely on the platform to do it, or handle it in common so that we have a guaranteed unified behavior.)

Message last modified on Jan 25, 2021 10:24PM

si...@google.com <si...@google.com> #12Jan 26, 2021 06:02AM

Marked as fixed.

The immediate exception is fixed.
Serializing AnnotatedString and other classes has to be done
Multistyle text editing already is not supported, the change that caused the exception was to provide an API so that we wont change it later.
Therefore closing this ticket and creating another ticket for AnnotatedString serialization.

Message last modified on Jan 26, 2021 06:07AM