TextFieldValue/AnnotatedString/TextRange/SpanStyle/ParagraphStyle Saver [178446304]

Fixed

Bug

Status Update

No update yet.

Description

si...@google.com

created issue #1

Jan 26, 2021 06:05AM

Forked from b/178312246

We need to implement the Saver objects for TextFieldValue/AnnotatedString/TextRange/SpanStyle/ParagraphStyle

Andrey described how to do it at b/178312246#comment4

Please check b/178312246 for more details on how to do it, and how to test it.

Comments

si...@google.com <si...@google.com> Apr 8, 2021 11:30PM

Reassigned to si...@google.com.

si...@google.com <si...@google.com> Apr 14, 2021 11:01PM

Accepted by si...@google.com.

ap...@google.com <ap...@google.com> #2Apr 19, 2021 05:02PM

Project: platform/frameworks/support
Branch: androidx-main

commit ed90c9a382eb2afe65b62765519e6256edc76195
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Apr 15 11:12:47 2021

Add ParagraphStyle/SpanStyle Saver

Preparation for TextFieldValue/AnnotatedString Savers.
- After a concern about dependencies collected all
savers to the same file un ui-text.
- We want to make those savers public, however since
the module of those Savers requires discussion,
will move the Savers in another CL.

RelNote: "Added TextUnit constructor function
TextUnit(value: Float, type: TextUnitType)"

Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT

Bug: 178446304
Change-Id: I7eccedda948c374d0cab1e883a56294aa9007b68

M compose/ui/ui-text/api/1.0.0-beta06.txt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_1.0.0-beta06.txt
M compose/ui/ui-text/api/restricted_current.txt
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-unit/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/TextUnit.kt

https://android-review.googlesource.com/1675372

ap...@google.com <ap...@google.com> #3Apr 20, 2021 07:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit 3e6425cb44d32cd39f9bc7e1daacd78dfaa56552
Author: Siyamed Sinir <siyamed@google.com>
Date: Fri Apr 16 23:52:31 2021

Add LocaleList.Saver

Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT

Bug: 178446304
Change-Id: I24412b7f8e19191e2450c7241e256fd0fa47e9f7

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt

https://android-review.googlesource.com/1678467

ap...@google.com <ap...@google.com> #4Apr 20, 2021 07:38AM

Project: platform/frameworks/support
Branch: androidx-main

commit 9d7ad4e2c349f6c47555b15f7789068361b5006c
Author: Siyamed Sinir <siyamed@google.com>
Date: Fri Apr 16 20:39:10 2021

Add AnnotatedString Saver

- Added AnnotatedString Saver
- Added TextRange.Saver
- changed TextFieldValue.Saver to use
AnnotatedStringSaver and TextRange.Saver
- Added missing API
AnnotatedString.Builder.addTtsAnnotation
- Added missing API
AnnotatedString.Builder.withAnnotation for
String and TtsAnnotation

RelNote: "AnnotatedString save support to
TextFieldValue.Saver. Added addTtsAnnotation
and withAnnotation utility functions to
AnnotatedString.Builder
"

Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT

Bug: 178446304
Change-Id: I8cbdcfcdbe167ff7c68c760aebdd8affe2d8434e

M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/AnnotatedString.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/TtsAnnotation.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/TextFieldValue.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt

https://android-review.googlesource.com/1678466

si...@google.com <si...@google.com> #5May 13, 2021 04:39PM

this ticket is waiting fontFamily to be saved.

si...@google.com <si...@google.com> Nov 17, 2021 02:36AM

Reassigned to an...@google.com.

ca...@gmail.com <ca...@gmail.com> #6Apr 15, 2024 03:39PM

might be related to b/334682521

so...@google.com <so...@google.com> #7Apr 15, 2024 04:03PM

Marked as fixed.

We have these Savers.

Outstanding work:

The ParagraphStyle Saver hasn't been updated with recent changes, tracked here b/333509433

*There were issues with a few Savers already fixed in aosp/3032063. There's an open ticket to cherry-pick it to the stable 1.6.5 release b/334682521.