performScrollTo doesn't support LazyLists [178483889]

Fixed

Feature Request

Status Update

No update yet.

Description

mv...@google.com

created issue #1

Jan 26, 2021 04:48PM

Compose 1.0.0-alpha11 doesn't support scrolling in tests in Lazy components (i.e. LazyColumn and LazyRow).

SemanticsNodeInteraction.performScrollTo fails to scroll to composables that hasn't been already composed.

Comments

pa...@google.com <pa...@google.com> #2Feb 3, 2021 04:43PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

mv...@google.com <mv...@google.com> #3Feb 5, 2021 07:12AM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ph...@monzo.com <ph...@monzo.com> #4Apr 16, 2021 12:06PM

deleted

pa...@google.com <pa...@google.com> Apr 20, 2021 12:23PM

Reassigned to je...@google.com.

je...@google.com <je...@google.com> #5Apr 20, 2021 01:59PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Apr 20, 2021 08:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 14511a46e45e620505a22c007211df14848e436c
Author: Jelle Fresen <jellefresen@google.com>
Date: Mon Mar 22 18:59:38 2021

Add scroll to item actions for LazyLists in tests

Defines a set of SemanticsPropertyKeys that are added in LazyList and
used in test actions to the effect of scrolling a LazyList to an item
that might not yet be composed.

Bug: 182259407
Bug: 178483889
Bug: 161584524
Fix: 183714443
Test: LazySemanticsTest, ScrollToIndexTest, ScrollToKeyTest
Relnote: "Added `SemanticsActions.ScrollToIndex` to scroll a list with
indexed items to the item with a certain index, and
`SemanticsProperties.IndexForKey` to get the index of an item in a list
with keyed items. Both actions are implemented by LazyList."
Relnote: "Added `SemanticsNodeInteraction.performScrollToIndex` that
scrolls a list to the given index, and
`SemanticsNodeInteraction.performScrollToKey` that scrolls a list to the
item with the given key."

Change-Id: I4fe63399fb620794651e1973730658877bcfeff4

M compose/foundation/foundation/api/1.0.0-beta06.txt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_1.0.0-beta06.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_1.0.0-beta06.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/lazy/LazySemanticsTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyList.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazySemantics.kt
M compose/ui/ui-test/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToIndexTest.kt
A compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToKeyTest.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Actions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Output.kt
M compose/ui/ui/api/1.0.0-beta06.txt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_1.0.0-beta06.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/semantics/SemanticsProperties.kt

https://android-review.googlesource.com/1649407

ap...@google.com <ap...@google.com> #7Aug 25, 2021 10:10AM

Project: platform/frameworks/support
Branch: androidx-main

commit 03a127f4328088d51d61998d47cdeacce5e94e74
Author: Jelle Fresen <jellefresen@google.com>
Date: Tue Aug 10 14:56:41 2021

Graduate lazy list test scroll API

Move performScrollToIndex, performScrollToKey, hasScrollToIndexAction
and hasScrollToKeyAction to supported API surface.

Bug: 178483889
Test: ./gradlew compose:ui:ui-test:cC
Relnote: "`performScrollToIndex`, `performScrollToKey`,
`hasScrollToIndexAction` and `hasScrollToKeyAction` are now stable API"

Change-Id: I142aefdd8455195d30a6b029b76255f1f737939f

M compose/ui/ui-test/api/current.txt
M compose/ui/ui-test/api/public_plus_experimental_current.txt
M compose/ui/ui-test/api/restricted_current.txt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToIndexTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/actions/ScrollToKeyTest.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Actions.kt
M compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt

https://android-review.googlesource.com/1791588

je...@google.com <je...@google.com> Sep 23, 2021 08:46AM

Accepted by je...@google.com.

je...@google.com <je...@google.com> #8Sep 30, 2021 10:23AM

Marked as fixed.

Fixed by aosp/1815782

al...@mercari.com <al...@mercari.com> #9Oct 21, 2021 10:11AM

Which Compose version has this been fixed?

je...@google.com <je...@google.com> #10Oct 21, 2021 11:06AM

performScrollToNode(matcher: SemanticsMatcher) was added in 1.1.0-alpha06

Note that by "fixed" I mean there is a solution, which is to use performScrollToNode(matcher: SemanticsMatcher) on the lazy list instead of performScrollTo() on the destination node.

oh...@mozilla.com <oh...@mozilla.com> #11Jun 24, 2022 12:44PM

We use the compose version 1.1.1 and while trying to scroll on a lazy list with performScrollToNode [ rule.onNode(hasScrollAction()).performScrollToNode(hasText(language)) ], I get this error:

java.lang.IllegalArgumentException: Failed requirement.
at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout(MeasureAndLayoutDelegate.kt:190)
at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout(AndroidComposeView.android.kt:662)
at androidx.compose.ui.node.Owner$DefaultImpls.measureAndLayout$default(Owner.kt:182)
at androidx.compose.ui.node.LayoutNode.forceRemeasure(LayoutNode.kt:1339)
at androidx.compose.foundation.lazy.layout.LazyLayoutState.remeasure(LazyLayoutState.kt:54)
at androidx.compose.foundation.lazy.LazyListState.snapToItemIndexInternal$foundation_release(LazyListState.kt:202)
at androidx.compose.foundation.lazy.LazyListState$scrollToItem$2.invokeSuspend(LazyListState.kt:194)
at androidx.compose.foundation.lazy.LazyListState$scrollToItem$2.invoke(Unknown Source:8)
at androidx.compose.foundation.lazy.LazyListState$scrollToItem$2.invoke(Unknown Source:4)

The only way it worked was by replacing scrollToItem(index) with animateScrollToItem(index) in the production code.

ma...@gmail.com <ma...@gmail.com> #12Mar 14, 2023 09:19PM

I had a similar error. My issue was solved when I found out that I called scrollToItem in from the IO dispatcher by accident, giving this same error.

se...@gmail.com <se...@gmail.com> #13Mar 18, 2023 08:36PM

Comment has been deleted.

Message last modified on Mar 18, 2023 09:55PM