Status Update
No update yet.
Comments
jo...@jossiwolf.de
Alon, can you take a look?
ma...@google.com
I was finally able to repro, and what happens is that if you finish the Gemini onboarding flow, you'll get the Ask Gemini text, but you have to restart the IDE to get the link to show up.
We need to fix that, or tweak the text before rebooting to either hide it or say something like ("reboot to enable Ask Gemini feature").
ni...@google.com
Background:
This feature is implemented by chaining together 2 separate pieces:
-
com/android/tools/idea/logcat/messages/MessageFormatter.ktadds the text "Ask Gemini". For every message from logcat, we check if it is an exception, and if so, add the text "Ask Gemini". -
A separate
EditorHyperlinkDetectoris responsible for "linkifying" the text. But this detector, only adds the studio bot specific logic if studio bot was enabled during initialization.
Due to the inconsistency in how (1) and (2) detect whether studio bot is available, we run into this situation when:
- On IDE start up, logcat is initializated. Studio Bot is not enabled at this time, so the hyper link detector doesn't add the studio bot specific logic.
- User on boards to Studio bot. After this, the MessageFormatter will start adding the text "Ask Gemini" for exceptions.
I think we should do a simple fix right away: We should always add the StudioBotFilter to the hyper link detector. This can then check for whether studio bot is enabled internally, which should make (1) and (2) consistent in how they check for studio bot being active.
cl...@google.com
as...@gmail.com
Can you also add an option to disable the feature, even if I logged in to Gemini?
We often share logcat output in bugreports and such. This is noise we can do without.
ta...@gmail.com
We often share logcat output in bugreports and such. This is noise we can do without.
Just want to confirm: you are copying logcat output from the logcat pane in Studio in your bugreports? (These aren't added to the real adb logcat output, they are only shown inside Studio, so they won't be in any automated bug report systems)
[Deleted User] <[Deleted User]>
This is a common practice at several teams I worked in, so it's not unique to my current workplace.
jo...@google.com
Sounds good. Adding a setting is tracked in
ga...@gmail.com
th...@gmail.com
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Ladybug Feature Drop | 2024.2.2 Canary 1
- Android Gradle Plugin 8.8.0-alpha01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
jo...@google.com
No updates to share yet. We're working on the underlying APIs at the moment to address this properly.
ap...@google.com
Branch: androidx-main
commit 3f94eba802caebc95f8f9055ffb572f6ee72ca2e
Author: Levi Albuquerque <levima@google.com>
Date: Thu Mar 16 15:15:20 2023
Migrating BottomDrawer to use SwipeableV2
Move BottomDrawer to use the new SwipeableV2 APIS.
Relnote: Update BottomDrawer internals to use the new SwipeableV2 APIs. Because of this BottomDrawerState will now only have APIS defined at the class level, it won't inherit methods/properties from SwipeableState. We're using composition with an internal SwipeableV2State. Offset is now a nullable floating point property, the current value and a swipe target value can still be accessed through currentValue and targetValue properties. The previous class level methods such as open/expand/close and properties such as isOpen/isClosed continue to be supported.
Test: Updated tests and added new ones.
Fixes: 178529942
Fixes: 220676296
Change-Id: Iad40c08ca8f48afbc451191c788e80584e874b98
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/DrawerTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Drawer.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material:material:1.5.0-alpha03
Description
When in landscape and the initial state value is set to
BottomDrawerValue.Expanded,BottomDrawerLayoutwill crash because there's no associated anchor. The same thing goes forModalBottomSheetValue.HalfExpandedwhen the sheet height is less thanfullHeight / 2.BottomDrawerLayoutandModalBottomSheetLayoutshould coerce into the nearest state if the requested initial one is not present.I'll post stacktraces + repro later!