Remove unnecessary "data class" from public API [178659281]

Fixed

Bug

Status Update

No update yet.

Description

ae...@google.com

created issue #1

Jan 28, 2021 03:02AM

With the below command, I see Compose has 46 data classes in our public API. This commits us to supporting APIs like equals() and component1(). It means among other things that changing the order of non-constructor fields in the class would be a breaking API change. We should do a cleanup pass and remove "data" except in the few cases where destructuring style is part of our documented sample code.

frameworks/support/compose$ git grep 'method public.*component1();' -- */current.txt

Comments

si...@google.com <si...@google.com> #2Jan 28, 2021 03:05AM

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

ae...@google.com <ae...@google.com> #3Jan 28, 2021 03:12AM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

Message last modified on Jan 28, 2021 03:12AM

lp...@google.com <lp...@google.com> #4Jan 28, 2021 03:17PM

Another problem I am facing with autofill is that it won't save my credentials. I tried forcing to finish the context as described here, but it won't do that either although I filled in the username with the one provided by the Google autofill service.

ae...@google.com <ae...@google.com> #5Jan 28, 2021 08:40PM

deleted

an...@google.com <an...@google.com> #6Jan 28, 2021 09:23PM

Facing the same issue here, Google autofill service seems to work. Zero documentation on adding support for Autofill framework on jetpack compose.

ae...@google.com <ae...@google.com> #7Feb 2, 2021 12:34AM

Hello, I am trying to implement the same thing - it seems like there's no way for current password managers like 1Password or Bitwarden, to automatically pick up the fields. Is there a possible solution?

si...@google.com <si...@google.com> #8Feb 2, 2021 01:31AM

I setup this modifier:

@OptIn(ExperimentalComposeUiApi::class)
fun Modifier.autofill(
    autofillTypes: List<AutofillType>,
    onFill: ((String) -> Unit),
) = composed {
    val autofill = LocalAutofill.current
    val autofillNode = AutofillNode(onFill = onFill, autofillTypes = autofillTypes)
    LocalAutofillTree.current += autofillNode

    this.onGloballyPositioned {
        autofillNode.boundingBox = it.boundsInWindow()
    }.onFocusChanged { focusState ->
        autofill?.run {
            if (focusState.isFocused) {
                requestAutofillForNode(autofillNode)
            } else {
                cancelAutofillForNode(autofillNode)
            }
        }
    }
}

And use it like this:

val emailState = remember { EmailState() }
Email(
    modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    ),
    emailState = emailState,
    onImeAction = { onForgotPasswordSubmitted(emailState.text) }
)

With these steps, autofill works for me.

ae...@google.com <ae...@google.com> #9Feb 2, 2021 03:26AM

@lo...@gmail.com comment#8

what version of compose are you using? I'm using latest alpha and the above doesn't work for me. 😭

ae...@google.com <ae...@google.com> #10Feb 2, 2021 06:04AM

Works perfectly fine on the latest stable and alpha versions. Did you check in my second comment if you enabled everything?

ap...@google.com <ap...@google.com> #11Feb 2, 2021 11:20PM

I believe so?

I copied the modifier and then used

modifier = Modifier.autofill(
        autofillTypes = listOf(
            AutofillType.Username,
            AutofillType.EmailAddress
        ),
        onFill = { emailState.text = it },
    )

on my text field.

ae...@google.com <ae...@google.com> Feb 4, 2021 09:52PM

Marked as fixed.