Remove unnecessary "data class" from public API [178659281]

Fixed

Bug

Status Update

No update yet.

Description

ae...@google.com

created issue #1

Jan 28, 2021 03:02AM

With the below command, I see Compose has 46 data classes in our public API. This commits us to supporting APIs like equals() and component1(). It means among other things that changing the order of non-constructor fields in the class would be a breaking API change. We should do a cleanup pass and remove "data" except in the few cases where destructuring style is part of our documented sample code.

frameworks/support/compose$ git grep 'method public.*component1();' -- */current.txt

Comments

si...@google.com <si...@google.com> #2Jan 28, 2021 03:05AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c9e90d1e5671b7e6a8880aecbe32bb13f4b37560
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Oct 31 11:30:30 2019

Remove font related TODOs

- Ability to read font weight from the font

b/143700963

- Support for font collections

b/122476423

- Support for variable fonts

b/143703328

- support for multiple font family

b/127483182

- BaselineShift.lerp

b/143699225

Test: ./gradlew ui:ui-text:test
Test: ./gradlew ui:ui-text:connectedAndroidTest

Bug: 141645236
Bug: 143700963
Bug: 122476423
Bug: 143703328
Bug: 127483182
Bug: 143699225
Change-Id: I4ff001fd1e0fff4cd3aa0c64efae929057e8d5de

M ui/ui-text/api/0.1.0-dev03.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev03.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev03.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/main/java/androidx/ui/text/font/Font.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/AndroidParagraphHelper.kt
M ui/ui-text/src/main/java/androidx/ui/text/platform/TypefaceAdapter.kt
M ui/ui-text/src/main/java/androidx/ui/text/style/BaselineShift.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontFamilyTest.kt
M ui/ui-text/src/test/java/androidx/ui/text/font/FontTest.kt

https://android-review.googlesource.com/1156568

https://goto.google.com/android-sha1/c9e90d1e5671b7e6a8880aecbe32bb13f4b37560

ae...@google.com <ae...@google.com> #3Jan 28, 2021 03:12AM

from dupped ticket

"CSS has font-variation-settings attribute
Also check if there are commonly used settings that we can add to the API.

Note:
Tracking ticket based on

https://docs.google.com/document/d/1MzK83egP-Jghc2ZW8IcIcJkud_vMM7jgDClCv4CkO_c/edit#bookmark=id.nyju92hr2ygw"

Message last modified on Jan 28, 2021 03:12AM

lp...@google.com <lp...@google.com> #4Jan 28, 2021 03:17PM

bulk comment, fyi: we have added icebox to all the tickets because it was suggested by blintz in order to prevent auto-close tickets. we want to keep our Compose tickets to remain opened.

see

b/123001228#comment6

ae...@google.com <ae...@google.com> #5Jan 28, 2021 08:40PM

discussion from aosp/1672420

variable font settings can be included during font creation (for Font() functions.)

there are two parts of the story:

This font is weight X
I want to render the text in weight Y (regardless of the font weight)

an...@google.com <an...@google.com> #6Jan 28, 2021 09:23PM

important for Material.

ae...@google.com <ae...@google.com> #7Feb 2, 2021 12:34AM

Project: platform/frameworks/support
Branch: androidx-main

commit 8766bf0012613dfa48fdc969d03bd64217a4460c
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:17:37 2022

Add font variations to Android font constructors

On O+ this will allow configuring font variation settings.

Bug:

b/143703328

Test: ./gradle :compose:ui:ui-text:cAT
Relnote: "Font constructors now accept a list of FontVariation.Setting for configuring variable fonts on O+ devices."
Change-Id: I11a9d69d73429e9a875fd7096a00981a0cbd8a47

M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/testutils/AsyncTestFonts.kt
M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidFontTest.kt
A compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A testutils/testutils-fonts/src/androidMain/assets/subdirectory/asset_variable_font.ttf
A testutils/testutils-fonts/src/font_ttx/variable_font.ttx
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFont.kt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/FontFamilyResolverImplTest.kt
A compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/AndroidVariableFontTest.kt
A testutils/testutils-fonts/src/commonMain/resources/font/variable_font.ttf

https://android-review.googlesource.com/2162835

si...@google.com <si...@google.com> #8Feb 2, 2021 01:31AM

Project: platform/frameworks/support
Branch: androidx-main

commit ef1fff276087529659dc11ae29b219fcc2e5c790
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 13:14:04 2022

FontVariation definition

Bug:

b/143703328

Relnote: "Add FontVariation API for defining and using variable fonts."
Test: ./gradlew :compose:ui:ui-text:test
Change-Id: I3c40c6c8b4cee02cacda9482955ec16587ae62a5

M compose/ui/ui-text/lint-baseline.xml
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/FontVariationTest.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2161039

ae...@google.com <ae...@google.com> #9Feb 2, 2021 03:26AM

Project: platform/frameworks/support
Branch: androidx-main

commit 80e8419233f7f46dbca44236c11df5a3692030c2
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Aug 03 11:01:22 2022

Add VariableFonts to ResourceFont

Add support on Android API26+

Test: New demo
Test: ./gradlew :com:ui:ui-text:cAT && ./gradlew :com:ui;ui-text:test

Relnote: "Resource Fonts now support setting font variation settings (API 26+)."
Bug:

b/143703328

Change-Id: I900dde1f539e580a66db9c14d389ada691377c91

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidFontLoader.android.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/Font.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/font/ResourceFontVariationSettingsTest.kt

https://android-review.googlesource.com/2172940

ae...@google.com <ae...@google.com> #10Feb 2, 2021 06:04AM

Project: platform/frameworks/support
Branch: androidx-main

commit 7ca15e8af5b4d7167667465d7f1a3e6f571526d0
Author: Sean McQuillan <seanmcq@google.com>
Date: Wed Jul 27 10:36:57 2022

Add variable fonts to DeviceFontFamilyNameFont

Relnote: "Variable font support in DeviceFontFamilyNameFont"
Test: ./gradlew :compose:ui:ui-text:cAT
Bug:

b/143703328

Change-Id: Ic1279b2dcb1c29e75b8037791179853a9f828c02

M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/AndroidLoadableFonts.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/PlatformTypefaces.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/font/FontVariation.kt
A compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/VariableFontsDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/TextDemos.kt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/font/DeviceFontFamilyNameFont.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/src/androidAndroidTest/kotlin/androidx/compose/ui/text/font/PlatformTypefacesTest.kt
M compose/foundation/foundation/integration-tests/foundation-demos/build.gradle

https://android-review.googlesource.com/2167512

ap...@google.com <ap...@google.com> #11Feb 2, 2021 11:20PM

Bugjuggler: b/241016309

ae...@google.com <ae...@google.com> Feb 4, 2021 09:52PM

Marked as fixed.

Issue 178659281

Description

Issue summary

Comments

si...@google.com <si...@google.com> #2Jan 28, 2021 03:05AM

ae...@google.com <ae...@google.com> #3Jan 28, 2021 03:12AM

lp...@google.com <lp...@google.com> #4Jan 28, 2021 03:17PM

ae...@google.com <ae...@google.com> #5Jan 28, 2021 08:40PM

an...@google.com <an...@google.com> #6Jan 28, 2021 09:23PM

ae...@google.com <ae...@google.com> #7Feb 2, 2021 12:34AM

si...@google.com <si...@google.com> #8Feb 2, 2021 01:31AM

ae...@google.com <ae...@google.com> #9Feb 2, 2021 03:26AM

ae...@google.com <ae...@google.com> #10Feb 2, 2021 06:04AM

ap...@google.com <ap...@google.com> #11Feb 2, 2021 11:20PM

ae...@google.com <ae...@google.com> Feb 4, 2021 09:52PM

Add comment

Issue metadata