Exception during IR lowering for boolean operators with @Composable functions [178702177]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

lp...@google.com

created issue #1

Jan 28, 2021 03:37PM

Was playing around with some code and I ran into this weird crash:

@Composable
fun ButtonDemo() {
    returnsBoolean() && returnsBoolean()
}

@Composable
fun returnsBoolean() = true

e: java.lang.IllegalStateException: Backend Internal error: Exception during IR lowering
File being compiled: ..src/main/java/androidx/compose/material/demos/ButtonDemo.kt
The root cause java.lang.AssertionError was thrown at: org.jetbrains.kotlin.backend.jvm.lower.JvmOptimizationLowering$lower$transformer$1.visitWhen(JvmOptimizationLowering.kt:196)
	at org.jetbrains.kotlin.backend.common.CodegenUtil.reportBackendException(CodegenUtil.kt:239)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invoke(PhaseBuilders.kt:124)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invoke(PhaseBuilders.kt:112)
	at org.jetbrains.kotlin.backend.common.phaser.NamedCompilerPhase.invoke(CompilerPhase.kt:94)
	at org.jetbrains.kotlin.backend.common.phaser.CompositePhase.invoke(PhaseBuilders.kt:30)
	at org.jetbrains.kotlin.backend.common.phaser.NamedCompilerPhase.invoke(CompilerPhase.kt:94)
	at org.jetbrains.kotlin.backend.common.phaser.CompilerPhaseKt.invokeToplevel(CompilerPhase.kt:41)
	at org.jetbrains.kotlin.backend.jvm.JvmLower.lower(JvmLower.kt:395)
	at org.jetbrains.kotlin.backend.jvm.JvmBackendFacade.doGenerateFilesInternal$backend_jvm(JvmBackendFacade.kt:138)
	at org.jetbrains.kotlin.backend.jvm.JvmBackendFacade.doGenerateFilesInternal$backend_jvm$default(JvmBackendFacade.kt:125)
	at org.jetbrains.kotlin.backend.jvm.JvmBackendFacade.doGenerateFiles(JvmBackendFacade.kt:112)
	at org.jetbrains.kotlin.backend.jvm.JvmIrCodegenFactory.generateModule(JvmIrCodegenFactory.kt:40)
	at org.jetbrains.kotlin.codegen.KotlinCodegenFacade.compileCorrectFiles(KotlinCodegenFacade.java:35)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinToJVMBytecodeCompiler.generate(KotlinToJVMBytecodeCompiler.kt:647)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinToJVMBytecodeCompiler.compileModules$cli(KotlinToJVMBytecodeCompiler.kt:210)
	at org.jetbrains.kotlin.cli.jvm.compiler.KotlinToJVMBytecodeCompiler.compileModules$cli$default(KotlinToJVMBytecodeCompiler.kt:162)
	at org.jetbrains.kotlin.cli.jvm.K2JVMCompiler.doExecute(K2JVMCompiler.kt:169)
	at org.jetbrains.kotlin.cli.jvm.K2JVMCompiler.doExecute(K2JVMCompiler.kt:52)
	at org.jetbrains.kotlin.cli.common.CLICompiler.execImpl(CLICompiler.kt:88)
	at org.jetbrains.kotlin.cli.common.CLICompiler.execImpl(CLICompiler.kt:44)
	at org.jetbrains.kotlin.cli.common.CLITool.exec(CLITool.kt:98)
	at org.jetbrains.kotlin.incremental.IncrementalJvmCompilerRunner.runCompiler(IncrementalJvmCompilerRunner.kt:371)
	at org.jetbrains.kotlin.incremental.IncrementalJvmCompilerRunner.runCompiler(IncrementalJvmCompilerRunner.kt:105)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.compileIncrementally(IncrementalCompilerRunner.kt:249)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.compile(IncrementalCompilerRunner.kt:89)
	at org.jetbrains.kotlin.daemon.CompileServiceImplBase.execIncrementalCompiler(CompileServiceImpl.kt:602)
	at org.jetbrains.kotlin.daemon.CompileServiceImplBase.access$execIncrementalCompiler(CompileServiceImpl.kt:93)
	at org.jetbrains.kotlin.daemon.CompileServiceImpl.compile(CompileServiceImpl.kt:1644)
	at jdk.internal.reflect.GeneratedMethodAccessor102.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:359)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:200)
	at java.rmi/sun.rmi.transport.Transport$1.run(Transport.java:197)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Transport.java:196)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:562)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:796)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:677)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:676)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.AssertionError: ANDAND condition should have an 'if true then false' body on its second branch. Failing expression: WHEN type=kotlin.Boolean origin=ANDAND
  BRANCH
    if: CALL 'public final fun returnsBoolean ($composer: androidx.compose.runtime.Composer?, $changed: kotlin.Int): kotlin.Boolean declared in androidx.compose.material.demos.ButtonDemoKt' type=kotlin.Boolean origin=null
      $composer: GET_VAR '$composer: androidx.compose.runtime.Composer? declared in androidx.compose.material.demos.ButtonDemoKt.ButtonDemo' type=androidx.compose.runtime.Composer? origin=null
      $changed: CONST Int type=kotlin.Int value=0
    then: BLOCK type=kotlin.Boolean origin=null
      CALL 'public abstract fun startReplaceableGroup (key: kotlin.Int): kotlin.Unit declared in androidx.compose.runtime.Composer' type=kotlin.Unit origin=null
        $this: GET_VAR '$composer: androidx.compose.runtime.Composer? declared in androidx.compose.material.demos.ButtonDemoKt.ButtonDemo' type=androidx.compose.runtime.Composer? origin=null
        key: CONST Int type=kotlin.Int value=1908225035
      VAR IR_TEMPORARY_VARIABLE name:tmp0_group type:kotlin.Boolean [val]
        CALL 'public final fun returnsBoolean ($composer: androidx.compose.runtime.Composer?, $changed: kotlin.Int): kotlin.Boolean declared in androidx.compose.material.demos.ButtonDemoKt' type=kotlin.Boolean origin=null
          $composer: GET_VAR '$composer: androidx.compose.runtime.Composer? declared in androidx.compose.material.demos.ButtonDemoKt.ButtonDemo' type=androidx.compose.runtime.Composer? origin=null
          $changed: CONST Int type=kotlin.Int value=0
      CALL 'public abstract fun endReplaceableGroup (): kotlin.Unit declared in androidx.compose.runtime.Composer' type=kotlin.Unit origin=null
        $this: GET_VAR '$composer: androidx.compose.runtime.Composer? declared in androidx.compose.material.demos.ButtonDemoKt.ButtonDemo' type=androidx.compose.runtime.Composer? origin=null
      GET_VAR 'val tmp0_group: kotlin.Boolean [val] declared in androidx.compose.material.demos.ButtonDemoKt.ButtonDemo' type=kotlin.Boolean origin=null
  BRANCH
    if: CONST Boolean type=kotlin.Boolean value=true
    then: BLOCK type=kotlin.Boolean origin=null
      CALL 'public abstract fun startReplaceableGroup (key: kotlin.Int): kotlin.Unit declared in androidx.compose.runtime.Composer' type=kotlin.Unit origin=null
        $this: GET_VAR '$composer: androidx.compose.runtime.Composer? declared in androidx.compose.material.demos.ButtonDemoKt.ButtonDemo' type=androidx.compose.runtime.Composer? origin=null
        key: CONST Int type=kotlin.Int value=-974564822
      CALL 'public abstract fun endReplaceableGroup (): kotlin.Unit declared in androidx.compose.runtime.Composer' type=kotlin.Unit origin=null
        $this: GET_VAR '$composer: androidx.compose.runtime.Composer? declared in androidx.compose.material.demos.ButtonDemoKt.ButtonDemo' type=androidx.compose.runtime.Composer? origin=null
      CONST Boolean type=kotlin.Boolean value=false

Doesn't crash if the function is not @Composable.

Comments

js...@google.com <js...@google.com> #2Jan 29, 2021 06:06PM

Known issue, we cannot do anything because AGP doesn't provide an API to fetch Kotlin sources (specifically here https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:buildSrc/private/src/main/kotlin/androidx/build/java/JavaCompileInputs.kt;l=88), i failed to find an FR for it, so it must have been a chat conversation.

ap...@google.com <ap...@google.com> #3Jun 23, 2021 09:22PM

Would you be opposed to failing the build if we see a src/kotlin directory?

le...@google.com <le...@google.com> Jul 13, 2021 10:13PM

Marked as fixed.

Issue 178702177

Description

Issue summary

Comments

js...@google.com <js...@google.com> #2Jan 29, 2021 06:06PM

ap...@google.com <ap...@google.com> #3Jun 23, 2021 09:22PM

le...@google.com <le...@google.com> Jul 13, 2021 10:13PM

Add comment

Issue metadata