Deprecate onImeActionPerformed [179071523]

Fixed

Feature Request

Status Update

No update yet.

Description

ra...@google.com

created issue #1

Feb 1, 2021 10:27PM

OnImeActionPerformed is being replaced by KeyboardActions. Deprecate and remove onImeActionPerformed

Comments

ra...@google.com <ra...@google.com> Feb 3, 2021 07:22PM

Accepted by ra...@google.com.

ap...@google.com <ap...@google.com> #2Feb 3, 2021 09:34PM

Project: platform/frameworks/support
Branch: androidx-main

commit 82855d6524106edd0668828d6c21b89c5903a82e
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Feb 03 00:11:06 2021

Deprecate onImeActionPerformed and replace it with KeyboardActions

Bug: 179071523
Test: ./gradlew compose:ui:ui-test:connectedCheck -P android.testInstrumentationRunnerArguments.class=androidx.compose.ui.test.TextActionsTest
Relnote: onImeActionPerformed is deprecated. use KeyboardActions instead
Change-Id: If0bbda1241018d4c19b5df3cd1811c38cce4a76d

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/CapitalizationAutoCorrectDemo.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeInputField.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/KeyboardSingleLineDemo.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/TextFieldSamples.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/OutlinedTextFieldTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/TextActionsTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/input/ImeAction.kt

https://android-review.googlesource.com/1572020

ra...@google.com <ra...@google.com> Feb 3, 2021 10:13PM

Marked as fixed.

so...@google.com <so...@google.com> Feb 4, 2021 10:58AM

Status: Assigned (reopened)

so...@google.com <so...@google.com> #3Feb 4, 2021 12:29PM

Hey Ralston,

I've just noticed today that onImeActionPerformed has not been removed from the CoreTextField, I assume this is needed to deprecate it from public API. Yet, the comment reference this closed ticket

    textStyle: TextStyle = TextStyle.Default,
    // TODO(b/179071523): Deprecate and remove onImeActionPerformed.
    onImeActionPerformed: (ImeAction) -> Unit = {},

If you're tracking this removal somewhere else, please ignore this and re-mark this bug as fixed :) Otherwise you might want to keep the bug open until you remove that parameter.

ra...@google.com <ra...@google.com> #4Feb 4, 2021 05:37PM

Accepted by ra...@google.com.

Thanks for pointing this out Anastasia. I was thinking of doing this as part of

b/178633932

.
This bug was only meant to deprecate onImeActionPerformed.

But the description of the bug and the code TODO says deprecate and remove.

Let's keep this bug open till I remove onImeActionPerformed.

Message last modified on Feb 4, 2021 05:38PM

ap...@google.com <ap...@google.com> #5Feb 5, 2021 12:36AM

Project: platform/frameworks/support
Branch: androidx-main

commit 4934ede8ef1985a875d383ef15adeddbfcba48fe
Author: Ralston Da Silva <ralu@google.com>
Date: Thu Feb 04 13:29:39 2021

Remove onImePerformed from CoreTextField

onImeActionPerformed has been replaced by keyboardActions.
This CL removes this parameter now that all the deprecated
functions using it were removed as part of aosp/1575163.

Bug: 179071523
Test: N/A
Change-Id: Id4853dd719779ff393d6b1a74b69da2c5b3ee620

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt

https://android-review.googlesource.com/1576604

ae...@google.com <ae...@google.com> Feb 9, 2021 05:35AM