Reference type aren't supported as deeplink arguments [179166693]

Fixed

Bug

androidx-bug-bounty

Status Update

No update yet.

Description

pa...@nearside.com

created issue #1

Feb 2, 2021 09:59PM

Component used: Navigation Version used: 2.3.3 (latest) Devices/Android versions reproduced on: n/a

setup:

destination (in Module B) has navigation arg of type reference
origin (in Module A) uses a deeplink with the query param ?description=R.string.foo
origin must toString R.string.foo in order to create a URI

Result:

java.lang.UnsupportedOperationException: References don't support parsing string values.

The workaround is obviously to change the nav arg type to String and call getString, but it's a weird limitation for sibling-module navigation.

Comments

il...@google.com <il...@google.com> #2Feb 2, 2021 10:04PM

Assigned to il...@google.com.

We also need documentation with a few examples for it.

pa...@nearside.com <pa...@nearside.com> #3Feb 2, 2021 10:06PM

Any progress with the documentation?

il...@google.com <il...@google.com> #4Feb 2, 2021 10:10PM

Changelists related to this issue will be linked once they are submitted.

ap...@google.com <ap...@google.com> #5Feb 10, 2021 01:55AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dc23f5c30d0394593e16a594c1502059f7e11140
Author: Ben Weiss <benweiss@google.com>
Date: Mon Mar 09 13:08:13 2020

Kotlin DSL for navigation-dynamic-features-*

Test: check & connectedCheck of affected modules

Bug: 148969800

Change-Id: Icd0cb16fbe7035aca6638c5fb984f27b6eb1ee0c

M navigation/navigation-dynamic-features-fragment/api/2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-fragment/api/current.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
M navigation/navigation-dynamic-features-fragment/src/androidTest/AndroidManifest.xml
A navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilderTest.kt
A navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilder.kt
M navigation/navigation-dynamic-features-runtime/api/2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-runtime/api/current.txt
M navigation/navigation-dynamic-features-runtime/api/public_plus_experimental_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-runtime/api/restricted_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-runtime/api/restricted_current.txt
A navigation/navigation-dynamic-features-runtime/src/androidTest/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigatorDestinationBuilderTest.kt
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt
A navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigatorDestinationBuilder.kt

https://android-review.googlesource.com/1253672

Issue 179166693

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Feb 2, 2021 10:04PM

pa...@nearside.com <pa...@nearside.com> #3Feb 2, 2021 10:06PM

il...@google.com <il...@google.com> #4Feb 2, 2021 10:10PM

ap...@google.com <ap...@google.com> #5Feb 10, 2021 01:55AM

Add comment

Issue metadata