detectTapGestures flakes and hangs in the down state on the emulator with mouse input [179239764]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Feb 3, 2021 11:55AM

What title says, we had to revert clickable to tapGestureFilters and other filters instead of using detectTapGestures because click wasn't fired sometimes under certain circumstances. More context:

After we migrated clickable to detectTapGestures, we were missing clicks on the buttons.

Symptoms: tap with regular speed, after click is up (lifted) sometimes ripple animates to pressed state and stays there and onClick is not fired. Reproducible not on every click and not for everyone.

Notable discoveries throughout exploration/revert:

It was reproducible only on emulators. All attempts to repro this on the
It was flaky, meaning that not everyone was able to reproduce it. 2.1 We were able to reproduce it on some linux machines that operates with mouse 2.2 We were able to reproduce it on the macs when you TAP on the trackpad. Not reproducible when you click.
Revert to tapGestureFilter fully solves the issue.

Seems like a timing/race issue when delay between down and up is very low, or smth along this lines.

It's an important issue to allow us to continue to migrate production code to suspend pointer to solve, hence p1.

Comments

ap...@google.com <ap...@google.com> #2Mar 24, 2021 11:13AM

Marked as fixed.

Hi,

I also see my text cut off when I set maxLines = 2. Is it the same issue?

  Box(
    modifier =
      Modifier.size(
        width = 108dp,
        height = 34dp,
      ),
    contentAlignment = Alignment.Center,
  ) {
    BasicText(
      text = "text text text",
      maxLines = 2,
      autoSize = AutoSize.StepBased(minFontSize = 1.sp, maxFontSize = 13.sp, stepSize = 0.2.sp),
    )
  }

ap...@google.com <ap...@google.com> #3Aug 19, 2021 02:40AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Jossi Wolf <jossiwolf@google.com>
Link: https://android-review.googlesource.com/3450389

Fix TextAutoSize bug with maxLines = 1

Expand for full commit details

Fix TextAutoSize bug with maxLines = 1 
 
We were overcaching the paragraphIntrinsics in MultiParagraphLayoutCache when mutating the style. For `AutoSizeStepBased` instances with biased windows (more values smaller/bigger than the optimal), this could result in performing layout with outdated intrinsics, and thus an outdated style and font size, without surfacing this in the TextLayoutResult. 
 
Test: New MultiParagraphLayoutCacheTests and manual testing 
Relnote: Fixed a bug in BasicText with TextAutoSize and maxLines set to 1. 
Fixes: 376834366 
 
Change-Id: Ic0450c763c5d764492995b44ee1fe570246a9689

Files:

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCacheTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/MultiParagraphLayoutCache.kt

Hash: e1b712d78cc60384ed67a56c006148291ba146a6
Date: Tue Jan 07 18:52:26 2025

Issue 179239764

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 24, 2021 11:13AM

ap...@google.com <ap...@google.com> #3Aug 19, 2021 02:40AM

Add comment

Issue metadata