Status Update
No update yet.
Comments
ap...@google.com
just query LocalView instead of setting this metadata at the ComposeView layer to unblock the most common cases.
As we can't know when / if the ComposeView is moved to a different part of the View hierarchy, we don't have a good callback / place to update this value within ComposeView - theoretically since shouldDelayChildPressedState is a function, it could return different values at different points in time in any case. So we should instead continue to query the view hierarchy during a press, to see if at that point in time we should delay the press or not.
So instead we just need to provide whether there is a scrollable Compose node, and then consumers can combine querying that with whether there is a scrollable ViewGroup, to work out whether they should delay presses or not. AndroidView can solely query whether it is in a scrollable Compose node, as anything inside it will look up the view hierarchy anyway
ap...@google.com
Branch: androidx-main
commit b9c029ef8bc7d6abe73b72bc4fb00e02da90b366
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Oct 18 23:43:49 2021
Delays PressInteractions if the Compose view is inside a scrolling ViewGroup
Updates ComposeView and other ViewGroups to correctly set shouldDelayChildPressedState to false
Bug:
Test: ClickableInScrollableViewGroupTest.kt
Change-Id: Ib7e000139d2bf39c9453fde38efbe2d84a6eac9a
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/Clickable.desktop.kt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableInScrollableViewGroupTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidViewsHandler.android.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ComposeView.android.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/viewinterop/AndroidViewHolder.android.kt
M compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/Clickable.android.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Clickable.kt
Description
What title says, we had to revert clickable to tapGestureFilters and other filters instead of using
detectTapGesturesbecause click wasn't fired sometimes under certain circumstances. More context:After we migrated clickable to detectTapGestures, we were missing clicks on the buttons.
Symptoms: tap with regular speed, after click is up (lifted) sometimes ripple animates to pressed state and stays there and onClick is not fired. Reproducible not on every click and not for everyone.
Notable discoveries throughout exploration/revert:
tapGestureFilterfully solves the issue.Seems like a timing/race issue when delay between down and up is very low, or smth along this lines.
It's an important issue to allow us to continue to migrate production code to suspend pointer to solve, hence p1.