detectTapGestures flakes and hangs in the down state on the emulator with mouse input [179239764]

Fixed

Bug

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Feb 3, 2021 11:55AM

What title says, we had to revert clickable to tapGestureFilters and other filters instead of using detectTapGestures because click wasn't fired sometimes under certain circumstances. More context:

After we migrated clickable to detectTapGestures, we were missing clicks on the buttons.

Symptoms: tap with regular speed, after click is up (lifted) sometimes ripple animates to pressed state and stays there and onClick is not fired. Reproducible not on every click and not for everyone.

Notable discoveries throughout exploration/revert:

It was reproducible only on emulators. All attempts to repro this on the
It was flaky, meaning that not everyone was able to reproduce it. 2.1 We were able to reproduce it on some linux machines that operates with mouse 2.2 We were able to reproduce it on the macs when you TAP on the trackpad. Not reproducible when you click.
Revert to tapGestureFilter fully solves the issue.

Seems like a timing/race issue when delay between down and up is very low, or smth along this lines.

It's an important issue to allow us to continue to migrate production code to suspend pointer to solve, hence p1.

Comments

ap...@google.com <ap...@google.com> #2Mar 24, 2021 11:13AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

ap...@google.com <ap...@google.com> #3Aug 19, 2021 02:40AM

Project: platform/frameworks/support
Branch: androidx-main

commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 now with workaround for

https://youtrack.jetbrains.com/issue/KT-62653

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3156121

Issue 179239764

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 24, 2021 11:13AM

ap...@google.com <ap...@google.com> #3Aug 19, 2021 02:40AM

Add comment

Issue metadata