SafeArgs & Directions code generation lacks annotations [179463137]

Fixed

Bug

Status Update

No update yet.

Description

sy...@gmail.com

created issue #1

Feb 6, 2021 09:13AM

Component used: Navigation

Version used: 2.3.3

Devices/Android versions reproduced on: n/a

When adding an argument to a navigation-destination, for example:

<argument android:name="id" android:defaultValue="-1L" app:argType="long" />

Task :compileDebugJavaWithJavac complains due to missing annotations in the generated code:

SomeFragmentArgs.java:19: warning: [unchecked] unchecked call to putAll(Map<? extends K,? extends V>) as a member of the raw type HashMap
    this.arguments.putAll(argumentsMap);
                         ^
  where K,V are type-variables:
    K extends Object declared in class HashMap
    V extends Object declared in class HashMap

SomeFragmentArgs.java:91: warning: [unchecked] unchecked call to putAll(Map<? extends K,? extends V>) as a member of the raw type HashMap
      this.arguments.putAll(original.arguments);
                           ^
  where K,V are type-variables:
    K extends Object declared in class HashMap
    V extends Object declared in class HashMap

SomeFragmentArgs.java:105: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type HashMap
      this.arguments.put("id", id);
                        ^
  where K,V are type-variables:
    K extends Object declared in class HashMap
    V extends Object declared in class HashMap

SomeFragmentDirections.java:30: warning: [unchecked] unchecked call to put(K,V) as a member of the raw type HashMap
      this.arguments.put("id", id);
                        ^
  where K,V are type-variables:
    K extends Object declared in class HashMap
    V extends Object declared in class HashMap
4 warnings

Other methods in the generated code already would use @SuppressWarnings("unchecked").

Comments

il...@google.com <il...@google.com> Feb 10, 2021 01:05AM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Feb 26, 2021 06:06PM

Project: platform/frameworks/support
Branch: androidx-main

commit e9d805e6a2e740501db257b36b38a1de383a44aa
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Feb 25 19:54:42 2021

Add suppress annotations to java writer

Safe-Args was missing missing "unchecked" annotations for generated args
and direction classes in java. This change adds
@SuppressWarning("unchecked") to any method that puts args into the
HashMap.

RelNote: "Safe-Args now adds suppress annotations on the proper methods
when using java."
Test: ./gradlew --rerun-tasks navigation:navigation-safe-args-generator:test
Bug: 179463137

Change-Id: I8fbc577e6e16bc8b2441377df1a59f9f59abae56

M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragment$InnerFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragmentDirections.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/Next.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/SanitizedMainFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/SanitizedMainFragmentDirections.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/java/nested_overridden_action/InnerSettingsDirections.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/java/nested_overridden_action/SettingsDirections.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/java/nested_same_action/SettingsDirections.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/nav_generator_test/java/nested_same_action/SettingsFragmentDirections.java

https://android-review.googlesource.com/1607840

jb...@google.com <jb...@google.com> #3Feb 26, 2021 06:12PM

Marked as fixed.

This has been fixed internally in will be available in the Navigation 2.3.4 release.

Issue 179463137

Description

Issue summary

Comments

il...@google.com <il...@google.com> Feb 10, 2021 01:05AM

ap...@google.com <ap...@google.com> #2Feb 26, 2021 06:06PM

jb...@google.com <jb...@google.com> #3Feb 26, 2021 06:12PM

Add comment

Issue metadata