Fixed
Status Update
Comments
pa...@google.com <pa...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
Description
The text editing test APIs (e.g.
performTextInput
) currently take a parameter calledalreadyHasFocus
, and when it's false (the default) they click the middle of the text field before attempting to perform input. I find that for any non-trivial tests involving aTextField
I almost always have to explicitly set this totrue
, because clicking in the middle of the text field puts the cursor in an essentially arbitrary position.I think a better API would fetch the current state of the node and only focus it if isn't already focused (and probably set the selection to something well defined, like the end of the text). If it's important for the text field to already be focused the writer of the test can use
assertIsFocused()
.