Status Update
Comments
pa...@google.com <pa...@google.com> #2
First of all thanks for this detailed issue.
This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7
. I will look into this.
The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection
and InputMethodManager
documentation. However, this is understandable since TextView
implementation was also not respecting the behavior that is expected from Editors.
Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection
. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.
ap...@google.com <ap...@google.com> #3
Or is that option not available?
Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.
Description
The text editing test APIs (e.g.
performTextInput
) currently take a parameter calledalreadyHasFocus
, and when it's false (the default) they click the middle of the text field before attempting to perform input. I find that for any non-trivial tests involving aTextField
I almost always have to explicitly set this totrue
, because clicking in the middle of the text field puts the cursor in an essentially arbitrary position.I think a better API would fetch the current state of the node and only focus it if isn't already focused (and probably set the selection to something well defined, like the end of the text). If it's important for the text field to already be focused the writer of the test can use
assertIsFocused()
.