Remote onSurfaceDestroyed onFailure call failed [179800224]

Fixed

Bug

Status Update

No update yet.

Description

el...@gmail.com

created issue #1

Feb 10, 2021 11:25AM

Library version used: 1.0.0-beta.1

Devices/Android versions reproduced on: Galaxy S10e (SM-G9700) / Galaxy M51 (SM-M515F) / Galaxy S9+ (SM-G965F)

Android Auto version reproduced on: 6.0.615334-release

Sample project to trigger the issue.

The issue reported by end users and we see in crashlytics breadcrumbs that it occurs on AndroidAuto Service shutdown.

The issue could be related to https://issuetracker.google.com/u/1/issues/178107274 where CarSurfaceListener could not be set to null during the shutdown.

A bug report.

com.google.android.libraries.car.app.HostException: Remote onSurfaceDestroyed onFailure call failed
        at com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:5)
        at com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:13)
        at com.google.android.libraries.car.app.utils.zzb.run(zzb:8)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:237)
        at android.app.ActivityThread.main(ActivityThread.java:8167)
        at java.lang.reflect.Method.invoke(Method.java:-2)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)

Caused by: java.lang.IllegalStateException: Fragment [62a7b85: com.tomtom.gplaybeta.navapp.nds/com.tomtom.mykonosapp.MykonosCarService] not attached to a context.
        at android.os.Parcel.createException(Parcel.java:2096)
        at android.os.Parcel.readException(Parcel.java:2056)
        at android.os.Parcel.readException(Parcel.java:2004)
        at com.google.android.gms.internal.car_app.zzb.transactAndReadExceptionReturnVoid(zzb:22)
        at com.google.android.libraries.car.app.IOnDoneCallback$Stub$Proxy.onFailure(IOnDoneCallback:9)
        at com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:15)
        at com.google.android.libraries.car.app.utils.zzc.zza(zzc:1)
        at com.google.android.gms.base.R$string.com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:2)
        at com.google.android.libraries.car.app.utils.RemoteUtils.zza(RemoteUtils:13)
        at com.google.android.libraries.car.app.utils.zzb.run(zzb:8)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:237)
        at android.app.ActivityThread.main(ActivityThread.java:8167)
        at java.lang.reflect.Method.invoke(Method.java:-2)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)

Comments

li...@google.com <li...@google.com> #2Feb 10, 2021 05:23PM

Assigned to li...@google.com.

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

li...@google.com <li...@google.com> #3Feb 12, 2021 10:42PM

Great! Thanks a lot, I'll look for the live updates soon!

kr...@tomtom.com <kr...@tomtom.com> #4Feb 15, 2021 01:32PM

This happens soon after android auto service is destroyed. Sometimes we see android.intent.action.ACTION_POWER_DISCONNECTED event being received between service destruction and crash - I recon that user has detached phone from head unit when the app was running.

kr...@tomtom.com <kr...@tomtom.com> #5Feb 17, 2021 12:52PM

Another related case is that we sometimes do get this onSurfaceDestroyed but the service was already destroyed. This causes a bit of mayhem and requires to use additional guards against this case.

li...@google.com <li...@google.com> #6Feb 17, 2021 09:17PM

I am looking into mitigating these shutdown race conditions in a future release.

li...@google.com <li...@google.com> Feb 18, 2021 05:56PM

Accepted by li...@google.com.

kr...@tomtom.com <kr...@tomtom.com> #7Mar 8, 2021 09:19PM

Still happens with new androidx car app library

at androidx.car.app.utils.RemoteUtils$SurfaceCallbackStub.lambda$onSurfaceDestroyed$3(RemoteUtils:209)
        at androidx.car.app.utils.RemoteUtils$SurfaceCallbackStub.lambda$onSurfaceDestroyed$3$RemoteUtils$SurfaceCallbackStub(RemoteUtils:3)
        at i0.d.a.k0.c.a(Unknown:4)
        at androidx.car.app.utils.RemoteUtils.lambda$dispatchHostCall$0(RemoteUtils:115)
        at androidx.car.app.utils.-$$Lambda$RemoteUtils$hqdRHUgQFt6LDam0B8zarqtlYt0.run(-:1)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99

li...@google.com <li...@google.com> #8Mar 10, 2021 12:28AM

Marked as fixed.

We have fixed the issue now and it will be available in a following release

ap...@google.com <ap...@google.com> #9Mar 10, 2021 12:28AM

Project: platform/frameworks/support
Branch: androidx-main

commit 076857f2f01e8e30f8186cad44ce22192438073a
Author: Rafael Lima <therafael@google.com>
Date: Thu Feb 25 23:28:48 2021

Improvements to shutdown scenarios

1. Do not send calls to app level callbacks if the app is not at least
in created state
2. Do not crash the app if the host is dead while trying to send an IPC

Follow up review will stop dispatching calls from template related
callbacks (i.e. onClick, etc)

Relnote: "Improvements to not dispatch calls to app if its lifecycle is
not at least in a created state"
Test: Unit tests
Bug:180530156
Bug:179800224
Bug:177921120
Bug:178516889

Change-Id: I8696503d1a9859411c4a52fa73d2852c8b3383d9

M car/app/app-testing/src/main/java/androidx/car/app/testing/TestAppManager.java
M car/app/app-testing/src/main/java/androidx/car/app/testing/TestCarContext.java
M car/app/app-testing/src/main/java/androidx/car/app/testing/navigation/TestNavigationManager.java
M car/app/app/src/main/java/androidx/car/app/AppManager.java
M car/app/app/src/main/java/androidx/car/app/CarAppService.java
M car/app/app/src/main/java/androidx/car/app/CarContext.java
M car/app/app/src/main/java/androidx/car/app/HostDispatcher.java
M car/app/app/src/main/java/androidx/car/app/ScreenManager.java
M car/app/app/src/main/java/androidx/car/app/model/OnCheckedChangeDelegateImpl.java
M car/app/app/src/main/java/androidx/car/app/model/OnClickDelegateImpl.java
M car/app/app/src/main/java/androidx/car/app/model/OnItemVisibilityChangedDelegateImpl.java
M car/app/app/src/main/java/androidx/car/app/model/OnSelectedDelegateImpl.java
M car/app/app/src/main/java/androidx/car/app/model/SearchCallbackDelegateImpl.java
M car/app/app/src/main/java/androidx/car/app/navigation/NavigationManager.java
M car/app/app/src/main/java/androidx/car/app/utils/LogTags.java
M car/app/app/src/main/java/androidx/car/app/utils/RemoteUtils.java
M car/app/app/src/test/java/androidx/car/app/AppManagerTest.java
M car/app/app/src/test/java/androidx/car/app/CarAppServiceTest.java
M car/app/app/src/test/java/androidx/car/app/CarContextTest.java
M car/app/app/src/test/java/androidx/car/app/HostDispatcherTest.java
M car/app/app/src/test/java/androidx/car/app/navigation/NavigationManagerTest.java

https://android-review.googlesource.com/1607842