[FilledTextField] [OutlinedTextField] Support prefix/suffix in material text fields [179884561]

Fixed

Feature Request

Status Update

No update yet.

Description

so...@google.com

created issue #1

Feb 10, 2021 12:38PM

There is a leadingIcon and trailingIcon APIs in the text field that are intended to be used to put an icon or iconbutton. But it was not designed to be used with prefix/suffix text as it requires a baseline alignment. We need to explore how to nicely support this.

Possibly related ticket: 1

Comments

ni...@google.com <ni...@google.com> #2Jun 15, 2021 01:09PM

Status: New

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ma...@google.com <ma...@google.com> #3Jun 18, 2021 11:12AM

Assigned to so...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

so...@google.com <so...@google.com> #4Feb 10, 2022 06:48PM

Reassigned to ma...@google.com.

This could be added as a slot API into TextFieldDecorationBox.

Not a huge priority given that it could be achieved with something like this for example:

BasicTextField() { innerTextField -> 
  TextFieldDecorationBox(
    innerTextField = {
      Row {
        val alignModifier = Modifier.alignByBaseline()
        Text("$", alignModifier.padding(end = 4.dp)) // prefix
        Box(alignModifier.weight(1f)) { innerTextField() }
        Text(".00", alignModifier) // suffix
      }
    }
  )
}

ni...@google.com <ni...@google.com> #5Sep 12, 2022 06:37PM

Could you please check if this is on the correct iteration?

ma...@google.com <ma...@google.com> Dec 13, 2022 08:13PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #6Jan 31, 2023 04:28PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit c15bd36a088423392f6d607d0dd1a951a0d31702
Author: Max Alfonso-Ying <maxying@google.com>
Date: Wed Jan 25 00:38:05 2023

Add goldens for text field prefix/suffix.

Bug:

b/179884561

Change-Id: I6522629d366b1249fdfcd887e9e8402ee32c7df6

A compose/material3/material3/outlinedTextField_prefixSuffix_withLabelAndInput_cuttlefish.png
A compose/material3/material3/outlinedTextField_prefixSuffix_withLabelAndInput_darkTheme_cuttlefish.png
A compose/material3/material3/outlinedTextField_prefixSuffix_withLabelAndInput_focused_cuttlefish.png
A compose/material3/material3/outlinedTextField_prefixSuffix_withLeadingTrailingIcons_cuttlefish.png
A compose/material3/material3/outlinedTextField_prefixSuffix_withPlaceholder_cuttlefish.png
A compose/material3/material3/textField_prefixSuffix_withLabelAndInput_cuttlefish.png
A compose/material3/material3/textField_prefixSuffix_withLabelAndInput_darkTheme_cuttlefish.png
A compose/material3/material3/textField_prefixSuffix_withLabelAndInput_focused_cuttlefish.png
A compose/material3/material3/textField_prefixSuffix_withLeadingTrailingIcons_cuttlefish.png
A compose/material3/material3/textField_prefixSuffix_withPlaceholder_cuttlefish.png

https://android-review.googlesource.com/2402252

ap...@google.com <ap...@google.com> #7Jan 31, 2023 04:28PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit d747bed10677621f865067e57a6099c7179502c3
Author: Max Alfonso-Ying <maxying@google.com>
Date: Tue Jan 03 17:50:57 2023

Implement prefix/suffix for M3 text field.

Fixes:

b/179884561

Test: added
Relnote: "Slot APIs for prefix and suffix text have been
added to Material 3 text fields."
Change-Id: Ia85786c582981e8f16a7053a869e06c2c1a43fb8

M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/TextFieldSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/OutlinedTextFieldScreenshotTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/OutlinedTextFieldTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/TextFieldScreenshotTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/TextFieldTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/OutlinedTextField.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextField.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextFieldDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/TextFieldImpl.kt

https://android-review.googlesource.com/2400915

pr...@google.com <pr...@google.com> #8Feb 8, 2023 06:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.0-alpha06

ya...@gmail.com <ya...@gmail.com> #9Feb 29, 2024 11:55AM

your text fields in compose are terrible