Memmory Leak [179925887]

Fixed

Bug

Status Update

No update yet.

Description

dz...@gmail.com

created issue #1

Feb 10, 2021 08:23PM

Component used: androidx.appcompat:appcompat
Version used: 1.3.0-beta01
Devices/Android versions reproduced on:
OnePlus 8 (API30), OnePlus 2 (API23), Emulator (API30)
Repository:

https://github.com/dzgeorgy/TextFieldMemmoryLeak
Steps to reproduce: Select input field -> Click button to navigate to new fragment (via Navigation library) -> Check notification for LeakCanary message (After returning back via back button all objects are garbage collected, but if you close app via home button you will receive warning from LeakCanary).
Additional info: It seems like there is no such problem in alpha02 version

Leak canary.txt

6.1 KB

Download

Comments

al...@google.com <al...@google.com> #2Feb 10, 2021 09:01PM

Reassigned to jb...@google.com.

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

il...@google.com <il...@google.com> #3Feb 10, 2021 09:33PM

Status: Duplicate of

170127848

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

dz...@gmail.com <dz...@gmail.com> #4Feb 10, 2021 09:49PM

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

il...@google.com <il...@google.com> Feb 10, 2021 10:32PM

Status: Assigned (reopened)

jb...@google.com <jb...@google.com> Feb 22, 2021 05:22PM

Status: Duplicate of

144410015

ap...@google.com <ap...@google.com> #5Feb 22, 2021 08:43PM

@ #4:

I think that is intended for Animator. If you set the currentPlayTime to 0 or the total duration the animator completes. We do some special checks in fragments to handle it.

jb...@google.com <jb...@google.com> Feb 22, 2021 08:45PM

Status: Assigned (reopened)

jb...@google.com <jb...@google.com> #6Feb 22, 2021 10:17PM

Marked as fixed.

Did some investigation on the Fragment side and it seems like the merged transition is targeting correctly.

Exiting Transition: Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
>>>>> ExitingViews <<<<<
View: android.widget.LinearLayout{f9add3d}
Entering Transition: Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
>>>>> EnteringViews <<<<<
View: android.widget.LinearLayout{b7f24bc}
Final merged transition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})
merged transition passed to controlDelayedTransition: TransitionSet@7bc1c45: 
      TransitionSet@e133f9a: 
        Slide@aa9288e: tgts(android.widget.LinearLayout{f9add3d})
      Slide@35b8af: tgts(android.widget.LinearLayout{b7f24bc})

Still digging.