Fixed
Status Update
No update yet.
Comments
il...@google.com
Fragments is a bit of an overloaded term, but yes, I would expect that URI fragments (the text following #) should be treated similarly to how query parameters are handled in that parsed arguments do not cross the # boundary between the path and fragment.
jb...@google.com
jb...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit dc62b652110eecd092410e7f69cbb618657e3d67
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Oct 13 18:41:13 2021
Ensure that parsed arguments do not cross # boundary
Updating the parsing of arguments in NavDeepLink to
ensure that, pound signs are treated the same as question marks, in that
they are not crossed by the argument boundary.
RelNote: "`NavDeepLink` parsed arguments now consider
pound signs in the same way as question marks."
Test: NavDeepLinkTest
Bug: 180042703
Change-Id: I213095f3a5a34962657feb0e8631589765b0a1ca
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
https://android-review.googlesource.com/1893253
Branch: androidx-main
commit dc62b652110eecd092410e7f69cbb618657e3d67
Author: Sanura N'Jaka <sanura@google.com>
Date: Wed Oct 13 18:41:13 2021
Ensure that parsed arguments do not cross # boundary
Updating the parsing of arguments in NavDeepLink to
ensure that, pound signs are treated the same as question marks, in that
they are not crossed by the argument boundary.
RelNote: "`NavDeepLink` parsed arguments now consider
pound signs in the same way as question marks."
Test: NavDeepLinkTest
Bug: 180042703
Change-Id: I213095f3a5a34962657feb0e8631589765b0a1ca
M navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.kt
M navigation/navigation-common/src/androidTest/java/androidx/navigation/NavDeepLinkTest.kt
jb...@google.com
This has been fixed internally and will be available in the next Navigation release. You can try it out now by following the #7920620.
Description
Component used: Navigation
Version used: 2.3.3
Devices/Android versions reproduced on: Pixel 3a, Samsung Galaxy S10
If a deep link contains a fragment, we get the fragment value in addition to the expected path. You can reproduce this with the basic navigation sample by using this deeplink:
From Ian: