Deep links return fragments in argument value [180042703]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 12, 2021 10:28PM

Component used: Navigation

Version used: 2.3.3

Devices/Android versions reproduced on: Pixel 3a, Samsung Galaxy S10

If a deep link contains a fragment, we get the fragment value in addition to the expected path. You can reproduce this with the basic navigation sample by using this deeplink: www.example.com/user/morgan#foo. See attached screenshot.

From Ian:

I suspect it could be as easy as catching both ? and # in https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-common/src/main/java/androidx/navigation/NavDeepLink.java;l=153

Instead of just ?

nav-sample-fragment.png

79 KB

View

Download

Comments

il...@google.com <il...@google.com> #2Feb 12, 2021 10:32PM

Assigned to jb...@google.com.

We have logic to match exact deep links, since you have a path argument maybe this doesn't fall within that case.

But definitely feel free to upload a pull request with tests for this particular test case and we can work it out there.

jb...@google.com <jb...@google.com> Oct 6, 2021 04:52PM

Reassigned to sa...@google.com.

jb...@google.com <jb...@google.com> Nov 16, 2021 01:09AM

Reassigned to jb...@google.com.

ap...@google.com <ap...@google.com> #3Nov 16, 2021 05:27PM

I've created a pull request on GitHub. Can you check it?

I not sure about names picked for test functions.

jb...@google.com <jb...@google.com> #4Nov 16, 2021 05:56PM

Marked as fixed.

When will you have time to review this pull request? This change is important for our project.

Issue 180042703