Missing data in PointerEvent [180075467]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Feb 12, 2021 05:56PM

Hello.

There some pointer type specific information that currently isn't available via Pointer API. For example, which mouse button is pressed now. On Desktop we expose AWT raw event object so it's possible to get this info but not for Android.

It also convenient to have active keyboard modifiers, for example, I need it in this CL https://android-review.googlesource.com/c/platform/frameworks/support/+/1578803

Both Android and AWT event objects contain this information

Comments

ig...@jetbrains.com <ig...@jetbrains.com> #2Feb 18, 2021 05:02PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b2ae0a8c9429e6def582fda75e85f76540a31192
Author: Ralston Da Silva <ralu@google.com>
Date: Thu Jul 09 18:55:04 2020

New Focus Modifier Implementation

This is the first CL in a series of CLs which implement the new focus API. The new implementation consists of multiple modifiers each implementing a specific use case.
This CL adds FocusModifier2 and ModifiedFocusNode2 (Which will be renamed to FocusModifier and ModifiedFocusNode after the existing classes are deleted).

Bug: 160924778
Relnote: Added Modifier.focus which replaces FocusModifier.
Test: Built and launched the demo app
Change-Id: Ib852a056a0f3c76757f0fdef07e75e82bf178b8d

M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/DelegatingLayoutNodeWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/InnerPlaceable.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNodeWrapper.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusModifier2.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusNodeUtils.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/ModifiedFocusNode2.kt

https://android-review.googlesource.com/1359576

[Deleted User] <[Deleted User]> #3Feb 19, 2021 09:15AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 79b361fcb1a863005e834f70a88cae274f6ca3ce
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Jul 13 18:34:14 2020

Instantiate a ModifiedFocusNode2 corresponding to a Modifier.focus() modifier

Bug: 160924778
Test: Built and launched the demo app
Change-Id: Ib5e045621e36a72327acf148bb1698632ffe182f

M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt

https://android-review.googlesource.com/1362065

ma...@google.com <ma...@google.com> #4Feb 22, 2021 05:22PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit a52a858283c3ee5af05036e1e3665784a3051f4f
Author: Ralston Da Silva <ralu@google.com>
Date: Mon Jul 13 18:19:31 2020

Add a modifier to request focus changes

Bug: 161182057, 160924778
Relnote: Added a modifier to request focus changes
Test: Built and launched the demo App.
Change-Id: I8dd73cf3ce77e112a9f97f203b8ec7a0f07bc706

M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusRequester.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/FocusRequesterModifier.kt
A ui/ui-core/src/commonMain/kotlin/androidx/ui/core/focus/ModifiedFocusRequesterNode.kt

https://android-review.googlesource.com/1362064

ra...@google.com <ra...@google.com> #5Feb 22, 2021 08:58PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c8c1ab4e79928727f722e5c946c7342dd9fa30f8
Author: Ralston Da Silva <ralu@google.com>
Date: Wed Jul 15 01:20:27 2020

Instantiate a ModifiedFocusNode2 corresponding to a Modifier.focus() modifier

Bug: 160924778
Test: Built and launched the demo app
Change-Id: Ide2b07ec55b65627d1a8cfedef55848807537bac

M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/LayoutNode.kt

https://android-review.googlesource.com/1363337

je...@google.com <je...@google.com> Jun 18, 2021 11:45AM

Assigned to mo...@google.com.

ap...@google.com <ap...@google.com> #6Aug 4, 2021 08:11PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 3d2e48d5818401ed48067469de79cfe9be07cba3
Author: George Mount <mount@google.com>
Date: Fri Jul 23 15:48:26 2021

Move desktop's button press and keyboard modifier to common

Fixes: 180075467

Desktop compose has added state for button presses and
modifiers. This CL moves that to common API.

RelNote: "PointerEvent now has support for reading
mouse button state and keyboard modifier state."

Test: new tests, new demo
Change-Id: I6310c8e6bd4d2e383389db7d4a33299aa1c52cd3

M compose/desktop/desktop/samples/src/jvmMain/kotlin/androidx/compose/desktop/examples/example1/Main.jvm.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/UiDemos.kt
A compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/gestures/ButtonMetaStateDemo.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/input/pointer/PointerEvent.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/input/pointer/PointerEvent.kt
M compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/input/pointer/PointerEvent.desktop.kt

https://android-review.googlesource.com/1776712

Issue 180075467